Make it possible to construct StackFrame without MethodBase #80681
Conversation
Contributes to dotnet#80165. Resolving a `MethodBase` is a pretty expensive operation and currently even a hello world needs it because of `Exception.ToString()`. This pull request is trying to get `MethodBase` out of the picture when constructing the exception string. We currently only need `_method` for two things - the public `GetMethod` API, and `StackFrame.ToString`. The `StackFrame.ToString` can already deal with `_method` being null (and that codepath exists solely for NativeAOT). This is the minimal change. We could potentially explore other approaches - leave `MethodBase` always at null, or unshare the `StackFrame` class.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsContributes to #80165. Resolving a We currently only need
|
|
|
||
| private bool TryInitializeMethodBase() | ||
| { | ||
| if (_noMethodBaseAvailable || _ipAddress == IntPtr.Zero) |
There was a problem hiding this comment.
Does this need to handle Exception.EdiSeparator?
| if (_method != null) | ||
| return true; | ||
|
|
||
| IntPtr methodStartAddress = RuntimeImports.RhFindMethodStartAddress(_ipAddress); |
There was a problem hiding this comment.
This can be just _ipAddress - _nativeOffset. (We can assert that it is same value as what RhFindMethodStartAddress returns.)
Contributes to #80165.
Resolving a
MethodBaseis a pretty expensive operation and currently even a hello world needs it because ofException.ToString(). This pull request is trying to getMethodBaseout of the picture when constructing the exception string.We currently only need
_methodfor two things - the publicGetMethodAPI, andStackFrame.ToString. TheStackFrame.ToStringcan already deal with_methodbeing null (and that codepath exists solely for NativeAOT). This is the minimal change. We could potentially explore other approaches - leaveMethodBasealways at null, or unshare theStackFrameclass.Cc @dotnet/ilc-contrib