Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Enable SIMD #80797

Merged
merged 38 commits into from
Mar 1, 2023
Merged

[wasm] Enable SIMD #80797

merged 38 commits into from
Mar 1, 2023

Commits on Jan 18, 2023

  1. [wasm] Enable SIMD

    radekdoulik committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    47be1e2 View commit details
    Browse the repository at this point in the history
  2. Let old V8 use simd

    Co-authored-by: Ankit Jain <radical@gmail.com>
    radekdoulik and radical committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    a0fc3eb View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. [wasm] ManagedToNativeGenerator: Skip unmanaged dlls

    .. instead crashing with an exception like:
    
    ```
    src/mono/wasm/build/WasmApp.Native.targets(296,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ManagedToNativeGenerator" task failed unexpectedly.
    System.BadImageFormatException: This PE image is not a managed executable.
       at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream)
       at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath)
       at PInvokeTableGenerator.Generate(String[] pinvokeModules, String[] assemblies, String outputPath) in /_/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42
       at ManagedToNativeGenerator.ExecuteInternal() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 68
       at ManagedToNativeGenerator.Execute() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 53
       at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
       at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
    ```
    
    The wasm targets currently are not able to differentiate the managed
    assemblies from the unmanaged ones. so it needs to be handled here.
    radical committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b695c92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c0ea37 View commit details
    Browse the repository at this point in the history
  3. [wasm] WasmApp.Native.targets: do not trigger relinking when WasmEnab…

    …leSIMD=true
    
    Instead, let the property be effective only for the AOT case.
    radical committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    cb53bc6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68da732 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Configuration menu
    Copy the full SHA
    b260375 View commit details
    Browse the repository at this point in the history
  2. [wasm] console template: Add --experimental-wasm-simd to node, and re…

    …move v8 config as that isn't supported
    radical committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    d12ab67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f68d50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    432e144 View commit details
    Browse the repository at this point in the history
  5. Try to pass full path to v8

    Also remove --experimental-wasm-simd option, which shouldn't be needed
    for newer v8
    radekdoulik committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a15b3ef View commit details
    Browse the repository at this point in the history
  6. Use docker image for all wasm helix jobs

    As we need newer v8
    radekdoulik committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    033d473 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Set DOTNET_CLI_HOME under workitem payload

    The correlation payload is read only
    radekdoulik committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5dec1aa View commit details
    Browse the repository at this point in the history
  2. Revert "Try to pass full path to v8"

    This reverts commit a15b3ef.
    radekdoulik committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    80f678a View commit details
    Browse the repository at this point in the history
  3. Use DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1

    Let see whether it will avoid all the writes to correlation payload
    path
    radekdoulik committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    7242ab8 View commit details
    Browse the repository at this point in the history
  4. Set NeedsEMSDKNode to false

    To try if we can use newer node in path
    radekdoulik committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    37080d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    7eb08b7 View commit details
    Browse the repository at this point in the history
  2. Revert "Set DOTNET_CLI_HOME under workitem payload"

    This reverts commit 5dec1aa.
    radekdoulik committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    aa544f4 View commit details
    Browse the repository at this point in the history
  3. Set DOTNET_CLI_HOME under workitem payload

    The correlation payload is read only. And even with
    `export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1` we have still many
    failures.
    radekdoulik committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    dc72268 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    9e1640a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca896d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Configuration menu
    Copy the full SHA
    b836780 View commit details
    Browse the repository at this point in the history
  2. Set _ExtraTrimmerArgs for tests

    So that linker substitution files are used
    radekdoulik committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1371cce View commit details
    Browse the repository at this point in the history
  3. Put the SIMD/trim related props in separate group

    More changes from Ankit
    radekdoulik committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    758d5b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Add dynamic dependency

    radekdoulik committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    f736fa5 View commit details
    Browse the repository at this point in the history
  2. Disable Vector128IsHardwareAcceleratedTest

    Til we have the interpreter support in place
    radekdoulik committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    42ce1df View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Configuration menu
    Copy the full SHA
    d8c5b6f View commit details
    Browse the repository at this point in the history
  2. Disable GenericVectorTests.IsHardwareAcceleratedTest

    Til we have the interpreter support in place
    radekdoulik committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3c02f89 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Disable check_no_intrinsic_cattr in emit_vector_2_3_4

    And add note about opened issue
    radekdoulik committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c401b52 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Configuration menu
    Copy the full SHA
    7e054d8 View commit details
    Browse the repository at this point in the history
  2. [mono] Disable few quaternion intrinsics

    For * and / operators as these are not the same as vector operations.
    Opened dotnet#82408 to implement
    correct ones in future.
    radekdoulik committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    143a73b View commit details
    Browse the repository at this point in the history
  3. Change comparison order

    radekdoulik committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    0114506 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Configuration menu
    Copy the full SHA
    2e0f09b View commit details
    Browse the repository at this point in the history
  2. Use stable images

    radekdoulik committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d05cb53 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Configuration menu
    Copy the full SHA
    44c4b13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aed4dd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Configuration menu
    Copy the full SHA
    cfc855e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e5505a View commit details
    Browse the repository at this point in the history