[wasm] Enable SIMD #80797
Merged
[wasm] Enable SIMD #80797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ankit Jain <radical@gmail.com>
|
Currently we fail on helix because v8 is too old. I am trying to improve that with 2 independent approaches, #80808 and dotnet/dotnet-buildtools-prereqs-docker#774 |
This was referenced Jan 19, 2023
.. instead crashing with an exception like: ``` src/mono/wasm/build/WasmApp.Native.targets(296,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ManagedToNativeGenerator" task failed unexpectedly. System.BadImageFormatException: This PE image is not a managed executable. at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream) at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath) at PInvokeTableGenerator.Generate(String[] pinvokeModules, String[] assemblies, String outputPath) in /_/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42 at ManagedToNativeGenerator.ExecuteInternal() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 68 at ManagedToNativeGenerator.Execute() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 53 at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) ``` The wasm targets currently are not able to differentiate the managed assemblies from the unmanaged ones. so it needs to be handled here.
…leSIMD=true Instead, let the property be effective only for the AOT case.
…move v8 config as that isn't supported
…runtime into pr-wasm-enable-simd
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Also remove --experimental-wasm-simd option, which shouldn't be needed for newer v8
As we need newer v8
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsLet see how it goes on CI
|
6 tasks
The correlation payload is read only
This reverts commit a15b3ef.
Let see whether it will avoid all the writes to correlation payload path
To try if we can use newer node in path
|
Azure Pipelines successfully started running 1 pipeline(s). |
radekdoulik
requested review from
radical,
pavelsavara,
kg,
vargaz,
lambdageek and
SamMonoRT
as code owners
lewing
reviewed
Feb 26, 2023
radical
reviewed
Feb 27, 2023
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The |
@maraf are you looking into this? |
kg
reviewed
Mar 1, 2023
kg
reviewed
Mar 1, 2023
kg
approved these changes
Mar 1, 2023
This was referenced Mar 29, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default value of
WasmEnableSIMDproperty to true. That enables SIMD for wasm/AOT.Use docker image with newer v8 and node on helix.