Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] X64 - Using cmovns for faster division #81252

Closed
wants to merge 4 commits into from
Closed

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Jan 27, 2023

Will resolve #41549 once I figure a few things out

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 27, 2023
@ghost ghost assigned TIHan Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Will resolve #41549 once I figure a few things out

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@TIHan TIHan changed the title [JIT] Using cmovns for faster division [JIT] X64 - Using cmovns for faster division Jan 27, 2023
@jakobbotsch
Copy link
Member

@TIHan I'd suggest waiting for #81267 to make it in and then solve this in the way @EgorBo suggested in the issue:

My working (ugly) prototype for RyuJIT: EgorBo@9b1d149 (I believe it should be done the other way - I'd introduce a GT_SELECT/GT_CMOV operator so we can later use it for other cmov-based optimizations, e.g. remove branches)

It should be less specific/pattern matchy.

@TIHan
Copy link
Contributor Author

TIHan commented Jan 27, 2023

@jakobbotsch - Ok, I can wait.

@ghost
Copy link

ghost commented Feb 26, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RyuJIT: Optimize "X / POW2_CNS" via cmovns
2 participants