[wasm] Don't publish the aot-instances.dll assembly, its not needed a… #84214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The target |
|
It should. |
|
Than we should move it the |
|
This assembly is still needed to be aot-ed, it just shouldn't be in the final bundle. |
|
I see, sorry. Than it should be |
vargaz
requested review from
lambdageek,
SamMonoRT,
thaystg and
MichalStrehovsky
as code owners
vargaz
force-pushed
the
wasm-no-aot-instances
branch
from
9c0887e
to
ba4cd66
Compare
maraf
approved these changes
Apr 3, 2023
…ny more. The runtime creates a dummy version of it internally.
vargaz
force-pushed
the
wasm-no-aot-instances
branch
from
ba4cd66
to
139a2dd
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ny more.
The runtime creates a dummy version of it internally.