-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NativeAOT] Fix System.Collections.Immutable.Tests #84552
Conversation
Tagging subscribers to this area: @dotnet/area-system-collections Issue Detailsnull
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSeems like frozen collections are broken again,
|
Seems to be a real issue? |
perhaps a testcase issue with some incompatible use of reflection that requires adding more stuff to rd.xml |
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There are errors on windows in
@MichalStrehovsky - is that supposed to work? |
We don't currently support it. It is doable, the work just wasn't done. The test should be conditioned on
Maybe we should start running a NativeAot leg on all PRs to this repo. We can now run a leg in 90 minutes or so. It's starting to be somewhat annoying that we need to mop up these things pretty much every week. Or if we could trigger it on any libs test change (not sure if that makes a meaningful difference). @agocke do you have an opinion? |
I think that will have little added value, so should not be a priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Yes. Every time these tests need to run it starts with fixing all kind of issues. I think that could be osx-arm64, since that does not run in a tiny VM. I've just checked and |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks!! |
Seems like immutable collections tests are broken again,
at least when run locally.
Let's see if it is a local issue or the tests are indeed broken.