Merged
Conversation
Member
mikelle-rogers
commented
Apr 24, 2023
mikelle-rogers
commented
- Updated documentation
- CoreCLR support
- Extensive updates to left-side logging
- Convert master/slave terminology to primary/replica based on https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/m/master-slave .
- Basic E2E has been validated in VS using Roslyn private bits
- Update inappropriate naming - Update many logging statements - Remove unused code
Fix off by one for string logging.
davidwrighton
approved these changes
Apr 25, 2023
2 tasks
noahfalk
approved these changes
Apr 25, 2023
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
I looked at the debug portions before, quickly rescanning and still looks fine. I didn't look much at the type-system changes for new fields. If that needs a closer review I'd need to take some time to better understand that area of the code and I assume @davidwrighton is already better versed on it.
hoyosjs
reviewed
Apr 25, 2023
hoyosjs
force-pushed
the
diag_generic_support
branch
from
41cad54 to
c492151
Compare
hoyosjs
approved these changes
Apr 25, 2023
This was referenced May 8, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.