Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function pointer type support to type loader #85287

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

MichalStrehovsky
Copy link
Member

So that we can create new function pointer types at runtime within the context of MakeGenericXXX.

Cc @dotnet/ilc-contrib

So that we can create new function pointer types at runtime within the context of `MakeGenericXXX`.
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

So that we can create new function pointer types at runtime within the context of MakeGenericXXX.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@@ -2434,6 +2435,97 @@ public static void Run()
}
}

class TestFunctionPointerLoading
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this test coverage on runtime flavors. Can this be regular tests that runs on all runtimes instead? (Either under src\tests or under src\libraries is fine.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about people "cleaning up" the MakeGeneric part or the statics. This test is written in a very specific way because it's for Native AOT. Libraries devs don't know about these subtleties.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(To be clear the concern is that this will be "cleaned up" in one of the 3000-line diffs when some analyzer enthusiast enables a new analyzer. I do look at things related to NativeAOT but I don't have the bandwidth to track the whole repo. The analyzer changes tend to cause subtle damage like this.)

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@MichalStrehovsky MichalStrehovsky merged commit 19d545c into dotnet:main Apr 25, 2023
@MichalStrehovsky MichalStrehovsky deleted the fnptrtl branch April 25, 2023 08:51
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants