-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function pointer type support to type loader #85287
Conversation
So that we can create new function pointer types at runtime within the context of `MakeGenericXXX`.
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSo that we can create new function pointer types at runtime within the context of Cc @dotnet/ilc-contrib
|
@@ -2434,6 +2435,97 @@ public static void Run() | |||
} | |||
} | |||
|
|||
class TestFunctionPointerLoading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use this test coverage on runtime flavors. Can this be regular tests that runs on all runtimes instead? (Either under src\tests or under src\libraries is fine.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried about people "cleaning up" the MakeGeneric
part or the statics. This test is written in a very specific way because it's for Native AOT. Libraries devs don't know about these subtleties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(To be clear the concern is that this will be "cleaned up" in one of the 3000-line diffs when some analyzer enthusiast enables a new analyzer. I do look at things related to NativeAOT but I don't have the bandwidth to track the whole repo. The analyzer changes tend to cause subtle damage like this.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks!
So that we can create new function pointer types at runtime within the context of
MakeGenericXXX
.Cc @dotnet/ilc-contrib