Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the RefreshMemoryLimit API public #85549

Merged
merged 1 commit into from
May 20, 2023
Merged

Make the RefreshMemoryLimit API public #85549

merged 1 commit into from
May 20, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Apr 28, 2023 •
edited
Loading

This change makes the RefreshMemoryLimit API public, this includes:

  • The NativeAOT implementation of the API
  • The Mono stub, and
  • Change the design to throw exceptions instead of returning error code, and
  • A few bug fixes

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@cshung cshung marked this pull request as draft April 28, 2023 23:57
@ghost ghost assigned cshung Apr 28, 2023
@ghost
Copy link

ghost commented Apr 28, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: -
Labels:

new-api-needs-documentation, area-NativeAOT-coreclr
Milestone: -

@cshung cshung changed the title Make the RefreshMemoryLimit API public [WIP] Make the RefreshMemoryLimit API public Apr 28, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 29, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 1, 2023
Closed
@cshung cshung force-pushed the public/turn-refresh-public branch from dab45e0 to 7910641 Compare May 16, 2023 17:27
@cshung cshung force-pushed the public/turn-refresh-public branch from 7910641 to 749803b Compare May 19, 2023 11:39
@build-analysis build-analysis bot mentioned this pull request May 19, 2023
Open
@cshung cshung force-pushed the public/turn-refresh-public branch from 749803b to 072c9d3 Compare May 19, 2023 20:28
@cshung cshung changed the title [WIP] Make the RefreshMemoryLimit API public Make the RefreshMemoryLimit API public May 19, 2023
@cshung cshung force-pushed the public/turn-refresh-public branch from 072c9d3 to 9e5d89a Compare May 19, 2023 20:36
@cshung cshung marked this pull request as ready for review May 19, 2023 22:00
Maoni0
Maoni0 approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build-analysis build-analysis bot mentioned this pull request May 20, 2023
Closed
3 tasks
@cshung cshung merged commit 5b09cbf into dotnet:main May 20, 2023
@cshung cshung deleted the public/turn-refresh-public branch May 20, 2023 03:31
@cshung cshung mentioned this pull request May 20, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@Maoni0 Maoni0 Maoni0 approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@cshung cshung

Labels
area-NativeAOT-coreclr new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cshung @jkotas @Maoni0