-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NativeAOT] Use inline relocs for win-arm64 INLINE_GETTHREAD #85689
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsnull
|
coreclr also uses I plan to do a similar change in coreclr separately and will look if the same can be done to ARM32. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks! |
We will use the same pattern as the most recent MSVC uses. That has fewer indirections and does not require
INLINE_GETTHREAD_CONSTANT_POOL
.Masm is very delicate about what mnemonics are used in this scenario, but can be convinced to emit the pattern.
INLINE_GET_TLS_VAR
for win-arm64