Remove Windows arm32 support #85947
Remove Windows arm32 support #85947
Conversation
Mostly, remove the CI runs. Windows arm32 product support was removed before .NET 6.
dotnet-issue-labeler
bot
added
the
needs-area-label
BruceForstall
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsMostly, remove the CI runs. Windows arm32 product support was removed before .NET 6.
|
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @dotnet/jit-contrib |
|
Comments, anyone? There are probably many more things that could be removed after this is merged. The primary goal here was to stop running win-arm builds and tests in the CI system. |
| - ${{ if and(eq(parameters.osGroup, 'windows'), eq(parameters.archType, 'arm')) }}: | ||
| - script: $(Build.SourcesDirectory)/src/coreclr/build-runtime$(scriptExt) $(buildConfig) $(archType) -hostarch x86 $(osArg) -ci $(compilerArg) -component crosscomponents -cmakeargs "-DCLR_CROSS_COMPONENTS_BUILD=1" $(officialBuildIdArg) $(clrRuntimePortableBuildArg) | ||
| displayName: Build CoreCLR Cross-Arch Tools (Tools that run on x86 targeting arm) | ||
|
|
There was a problem hiding this comment.
There's a condition in eng/Subsets.props that corresponds to this condition. Do we want to remove that as well?
There was a problem hiding this comment.
Yes. But that will be a follow-up.
|
There is more that can be cleaned up in the sources (e.g. delete src\coreclr\vm\arm*.asm). It can be done as a separate change. |
src/tests/run.cmd
Outdated
| @@ -200,7 +199,7 @@ echo. | |||
| echo where: | |||
| echo. | |||
| echo./? -? /h -h /help -help - View this message. | |||
| echo ^<build_architecture^> - Specifies build architecture: x64, x86, arm, or arm64 ^(default: x64^). | |||
| echo ^<build_architecture^> - Specifies build architecture: x64, x86, or arm64 ^(default: x64^). | |||
There was a problem hiding this comment.
Hmm, I'm still seeing linux_arm / linux_musl_arm jobs in the above pipelines, are we removing arm32 support even on these?
There was a problem hiding this comment.
No, linux-arm is still a supported platform. (But run.cmd is only used on Windows)
src/tests/issues.targets
Outdated
| <Issue>https://github.com/dotnet/runtime/issues/81241</Issue> | ||
| </ExcludeList> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Windows arm64 specific excludes --> |
There was a problem hiding this comment.
Not as part of this PR but I guess at some point we should audit this issue list and close those that are no longer relevant i.e. that only occur on the no longer supported Windows arm platform.
Since we don't support win-arm in .NET 6/7, that would make sense. |
Only change YML files to remove windows_arm runs. Don't build Windows arm cross components. Don't touch mono files. Changing scripts to remove builds, and remove code, can follow.
|
I decided to simplify this to only remove win-arm CI runs. Removing the ability to build via build scripting can happen later. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
win-arm CI builds were removed with dotnet#85947
win-arm CI builds were removed with #85947
ghost
locked as resolved and limited conversation to collaborators
Mostly, remove the CI runs. Windows arm32 product support was removed before .NET 6.