Make casting helpers look more like in CoreCLR #86029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up casting to interfaces by about 50%. Speeds up casting to classes by about 20%. There are small differences compared to CoreCLR: * NativeAOT runtime considers interfaces implementable by arrays to be variant. We don't need to special case casting arrays to non-variant (in IL sense) interfaces because those naturally take the variant paths. * The base type field on arrays holds the array element type so we need to check for the array case before starting to chase the base hierarchy. Otherwise the top level helpers now look mostly the same as the CoreCLR ones.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSpeeds up casting to interfaces by about 50%. Speeds up casting to classes by about 20%. There are small differences compared to CoreCLR:
Otherwise the top level helpers now look mostly the same as the CoreCLR ones. Cc @dotnet/ilc-contrib
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sergio0694
reviewed
May 10, 2023
jkotas
reviewed
May 10, 2023
...clr/nativeaot/System.Private.CoreLib/src/Internal/Reflection/Core/Execution/MethodInvoker.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2023
...clr/nativeaot/System.Private.CoreLib/src/Internal/Reflection/Core/Execution/MethodInvoker.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2023
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/TypeCast.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2023
| return null; | ||
| } | ||
| [RuntimeExport("RhTypeCast_CheckCastClassSpecial")] | ||
| private static unsafe object CheckCastClassSpecial(MethodTable* pTargetType, object obj) |
There was a problem hiding this comment.
It would be nice to unify the names with CoreCLR impl (Check vs. Chk) so that the implementations are easy to match (and eventually share). It can be separate rename-only PR.
VSadov
reviewed
May 10, 2023
VSadov
reviewed
May 10, 2023
VSadov
reviewed
May 10, 2023
|
I think this PR will resolve #84464 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up casting to interfaces by about 50%. Speeds up casting to classes by about 20%.
There are small differences compared to CoreCLR:
Otherwise the top level helpers now look mostly the same as the CoreCLR ones.
Cc @dotnet/ilc-contrib