Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haiku: Configuration support #86391

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Haiku: Configuration support #86391

merged 1 commit into from
Oct 24, 2023

Conversation

trungnt2910
Copy link
Contributor

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 17, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2023
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch 3 times, most recently from 8b9fb18 to af97252 Compare May 17, 2023 16:59
@vargaz
Copy link
Contributor

vargaz commented May 17, 2023

The mono changes look ok.

@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from af97252 to 79b7330 Compare May 17, 2023 17:29
@runfoapp runfoapp bot mentioned this pull request May 17, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 17, 2023
Closed
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from 79b7330 to 3b981e8 Compare May 18, 2023 00:31
@build-analysis build-analysis bot mentioned this pull request May 18, 2023
Open
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from 3b981e8 to 2c315d5 Compare May 26, 2023 13:37
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from 2c315d5 to e8d4f3c Compare May 28, 2023 12:35
This was referenced May 28, 2023
Closed
Closed
@danmoseley danmoseley added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 1, 2023
@ghost
Copy link

ghost commented Jun 1, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

Author: trungnt2910
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution, os-haiku
Milestone: -

@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from e8d4f3c to 75f5797 Compare June 2, 2023 08:41
This was referenced Jun 2, 2023
Closed
Closed
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from 75f5797 to 9195830 Compare June 5, 2023 04:03
@build-analysis build-analysis bot mentioned this pull request Jun 5, 2023
Closed
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch from 9195830 to 3012760 Compare June 7, 2023 12:00
@trungnt2910 trungnt2910 force-pushed the dev/trungnt2910/haiku-config branch 5 times, most recently from 91e7d16 to 98090da Compare July 31, 2023 06:55
@trungnt2910 trungnt2910 mentioned this pull request Aug 20, 2023
Open
@trungnt2910 trungnt2910 mentioned this pull request Sep 8, 2023
Merged
@ViktorHofer ViktorHofer mentioned this pull request Sep 18, 2023
Merged
am11
am11 approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@build-analysis build-analysis bot mentioned this pull request Oct 22, 2023
Closed
jkotas
jkotas approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any concerns with getting this PR merged?

@build-analysis build-analysis bot mentioned this pull request Oct 23, 2023
Closed
ViktorHofer
ViktorHofer approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libraries changes look good to me. I would like to change the four touched projects (Net.Http, Net.NetworkInformation, Net.Security and Serialization.Formatters) in the future so that we don't have to introduce new platform TFMs.

@jkotas
Copy link
Member

jkotas commented Oct 23, 2023

@trungnt2910 Could you please resolve the conflict?

@trungnt2910
Haiku: Configuration support
7338ea4 
Added more support for configuration for Haiku cross-compile
builds.
@trungnt2910
Copy link
Contributor Author

@trungnt2910 Could you please resolve the conflict?

Done.

This was referenced Oct 24, 2023
Closed
Closed
@jkotas
Copy link
Member

jkotas commented Oct 24, 2023

@trungnt2910 Thank you!

@jkotas jkotas merged commit d775a3b into dotnet:main Oct 24, 2023
186 of 189 checks passed
@trungnt2910 trungnt2910 mentioned this pull request Oct 25, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@akoeplinger akoeplinger akoeplinger left review comments

@tmds tmds tmds left review comments

@dsplaisted dsplaisted dsplaisted left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jkotas jkotas jkotas approved these changes

@am11 am11 am11 approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@marek-safar marek-safar Awaiting requested review from marek-safar

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member os-haiku
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.