Add a test for the first chance exception event to NativeAOT smoke tests #86560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsI was working on #2169 and wanted to add a test for this functionality - seems like it belongs upstream as other similar runtime-implemented callbacks (stack trace appending, unhandled exceptions) are already being tested.
|
SingleAccretion
force-pushed
the
First-Chance-Exc-NAOT-Test
branch
from
9e44cb1 to
caa5812
Compare
This was referenced May 22, 2023
MichalStrehovsky
approved these changes
May 22, 2023
Odd failure mode on Linux-ARM64 (I now see this is #85082) - we should rerun it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on #2169 and wanted to add a test for this functionality - seems like it belongs upstream as other similar runtime-implemented callbacks (stack trace appending, unhandled exceptions) are already being tested.