Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the LockCreated event to ContentionLockCreated #86817

Merged
merged 1 commit into from
May 30, 2023

Conversation

kouvel
Copy link
Member

@kouvel kouvel commented May 26, 2023

- The event was added in .NET 8, I have updated the event name based on the suggestion in microsoft/perfview#1731 (comment).
- The name now matches the convention used for most other events, and shows up as Contention/LockCreated as expected in PerfView
@kouvel kouvel added this to the 8.0.0 milestone May 26, 2023
@kouvel kouvel requested review from brianrob and davmason May 26, 2023 22:15
@kouvel kouvel self-assigned this May 26, 2023
@ghost
Copy link

ghost commented May 26, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: kouvel
Assignees: kouvel
Labels:

area-System.Threading

Milestone: 8.0.0

Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kouvel kouvel merged commit 7d50edd into dotnet:main May 30, 2023
@kouvel kouvel deleted the EventFix branch May 30, 2023 15:46
@ghost ghost locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants