Add ContentionStart_V2 and LockCreated events

[kouvel]

• Depends on Add new version of the ContentionStart event dotnet/runtime#72627

[kouvel]

For some reason the LockCreated event is showing up like this:

Event Name                                	Time MSec	Process Name          	Rest  
Microsoft-Windows-DotNETRuntime/Contention	5,172.485	Process(27972) (27972)	HasStack="True" ThreadID="9,656" ProcessorNumber="7" LockID="0x1da800c2a88" AssociatedObjectID="0x1db02916e80" ClrInstanceID="5" 

Any idea why the event name is not showing up? [Edit] Looks like it's because of TraceEvent.EventName's default behavior.

[kouvel]

CC @brianrob

[brianrob]

For some reason the LockCreated event is showing up like this:

Event Name                                	Time MSec	Process Name          	Rest  
Microsoft-Windows-DotNETRuntime/Contention	5,172.485	Process(27972) (27972)	HasStack="True" ThreadID="9,656" ProcessorNumber="7" LockID="0x1da800c2a88" AssociatedObjectID="0x1db02916e80" ClrInstanceID="5" 

Any idea why the event name is not showing up? [Edit] Looks like it's because of TraceEvent.EventName's default behavior.

Yes, this is because of how events get named. Can you update the runtime to use a new task called LockCreated? That should do it.

[kouvel]

Yes, this is because of how events get named. Can you update the runtime to use a new task called LockCreated? That should do it.

It seems to be working fine now after the latest commit, where the name is overridden.

Why does using the win:Info opcode cause the name to be different? It seems to be PerfView-specific logic.

From only one perspective, I'd actually like to see the event shown as Contention/LockCreated since it's relevant to the Contention keyword (and under the Contention task, which I think is correct). The pattern for that for all other opcodes seems to be that for PerfView the event should be named ContentionLockCreated, which is also awkward. Anyway, showing the event as LockCreated on its own without the task/keyword is probably ok for now, perhaps some fixes can be made to PerfView in the future to make it easier for events to show up as intended.

[brianrob]

Why does using the win:Info opcode cause the name to be different? It seems to be PerfView-specific logic.

Names are usually a combination of Task + Opcode when possible. There are a few different versions of ETW providers, and so this isn't always the case, but often it is. Each tool has to build its own logic as event names aren't encoded into the manifest directly.

From only one perspective, I'd actually like to see the event shown as Contention/LockCreated since it's relevant to the Contention keyword (and under the Contention task, which I think is correct). The pattern for that for all other opcodes seems to be that for PerfView the event should be named ContentionLockCreated, which is also awkward. Anyway, showing the event as LockCreated on its own without the task/keyword is probably ok for now, perhaps some fixes can be made to PerfView in the future to make it easier for events to show up as intended.

It seems reasonable to have it show up as Contention/LockCreated - the right way to do this is to create a LockCreated opcode, and then have the LockCreated event use the Contention task + LockCreated opcode. It's always possible to update PerfView to change things, but from a consistency POV, I would rather see us stick to the convention and change the event definition, especially for new events. If you'd like to change to this, I completely support that.

[kouvel]

I see, sounds good

[brianrob]

@kouvel, wanted to check back in on this. Are you planning to change this to be Contention/LockCreated, or should we merge as is?

[kouvel]

Yea I'm planning to change it, haven't found the time yet, it's on my list

[brianrob]

Sounds good. Just wanted to make sure. Thanks.

[kouvel]

Rebased to latest and added one commit to update the event name based on dotnet/runtime#86817 and to not override it. After dotnet/runtime#86817 and the latest commit, the event is showing up as Contention/LockCreated in PerfView as expected. This should be ready to review after dotnet/runtime#86817.

[brianrob]

Looks good - just one thing that I think we should change.

[brianrob]

It looks like this will show up as a Contention/Info event and not a LockCreated event. To fix this, you will want to create LockCreated opcode, and use that. Unless I've missed something, this is the event definition, using the win:Info opcode:

                    <event value="90" version="0" level="win:Informational"  template="LockCreated"
                           keywords ="ContentionKeyword"  opcode="win:Info"
                           task="Contention"
                           symbol="LockCreated" message="$(string.RuntimePublisher.LockCreatedEventMessage)"/>

[brianrob]

I stand corrected - I missed your pending change in dotnet/runtime: dotnet/runtime#86817. Once the change in dotnet/runtime is merged, I will merge this change as well.

[kouvel]

Thanks, I have merged dotnet/runtime#86817