[release/7.0-staging] [mono] Use underlying type in RuntimeHelpers.GetSpanDataFrom #87021
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Make it work correctly for spans of enums Fixes #86865 Note that in net8 RuntimeHelpers.CreateSpan<T> is an intrinsic, so GetSpanDataFrom is never called directly. But in net7 CreateSpan is not intrinsified on Mono, so the underlying method really does get called.
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
lambdageek
added
area-System.Runtime.CompilerServices
and removed
area-VM-meta-mono
labels
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsBackport of #87019 to release/7.0-staging /cc @lambdageek Customer ImpactCustomers can create TestingCI regression test RiskLow
|
|
Test failure is related. I guess the SDK on net7 doesn't produce exactly the same hidden field for the array data. |
rbhanda
added
Servicing-approved
| if (pid == null) | ||
| return 3; | ||
|
|
||
| var fi = pid.GetField("0B77DC554B4A81403D62BE25FB5404020AD451151D4203D544BF60E3FEDBD8AE", BindingFlags.Static | BindingFlags.NonPublic); |
There was a problem hiding this comment.
just curious, is this some kind of internal hash? is it stable?
There was a problem hiding this comment.
I believe it's a hash of the constant value. It's fairly stable - in local testing the same field is generated with the net8.0 and net7.0 SDKs when targeting both the net8.0 and net7.0 runtimes. In CI testing, for some reason the 7.0 branch creates a field with a name that is 1 character longer (ie that final "E" is here on the release/7.0-staging version of the test, but not in the main branch).
I could just blindly take the first matching field in the assembly (and maybe do some minimal checking of its attributes to make sure it's plausibly the correct one), but it seemed more straightforward to just hardcode the name and to return a distinct failure code and a print out of the available fields.
|
Remaining failures are all known |
ghost
locked as resolved and limited conversation to collaborators
Backport of #87019 to release/7.0-staging
/cc @lambdageek
Customer Impact
Customers can create
ReadOnlySpans from arrays of enum type in their apps targeting mobile and WebAssembly platforms.Fixes #86865
Testing
CI regression test
Risk
Low: existing code that runs correctly will continue working.