Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-staging] [mono] Use underlying type in RuntimeHelpers.GetSpanDataFrom #87021

Merged
merged 4 commits into from
Jun 7, 2023
Merged

[release/7.0-staging] [mono] Use underlying type in RuntimeHelpers.GetSpanDataFrom #87021

merged 4 commits into from
Jun 7, 2023

Commits on Jun 1, 2023

  1. [mono] Use underlying type in RuntimeHelpers.GetSpanDataFrom 

    Make it work correctly for spans of enums

Fixes #86865

Note that in net8 RuntimeHelpers.CreateSpan<T> is an intrinsic, so
GetSpanDataFrom is never called directly.

But in net7 CreateSpan is not intrinsified on Mono, so the underlying
method really does get called.
    @lambdageek
    lambdageek authored and github-actions committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    5e9ab0c View commit details
    Browse the repository at this point in the history

  2. fixup test

    @lambdageek
    lambdageek authored and github-actions committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    c4e2bf0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. test: Print all hidden field names if we can't find the right one

    @lambdageek
    lambdageek committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    65b4b02 View commit details
    Browse the repository at this point in the history

  2. fixup field name in test

    @lambdageek
    lambdageek committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f61bb61 View commit details
    Browse the repository at this point in the history