Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the order of AOT SDK and framework assemblies #88703

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Switch the order of AOT SDK and framework assemblies #88703

merged 1 commit into from
Jul 12, 2023

Commits on Jul 11, 2023

  1. Switch the order of AOT SDK and framework assemblies 

    When you have built a CoreCLR CoreLib, it "poisons" the build
s.t. running libraries tests with NAOT becomes impossible.

This is because $(IlcFrameworkPath) draws from a shared framework
that contains the CoreCLR CoreLib, while it should use the CoreLib
from the AOT SDK.

This targeted change changes the order in which these two assemblies
get passed to ILC and allows one to use "/p:TestNativeAot=true"
without additional workarounds.
    @SingleAccretion
    SingleAccretion committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6bfb3b8 View commit details
    Browse the repository at this point in the history