Add an option to not generate precise GC info

eng/testing/tests.singlefile.targets

@@ -1,5 +1,7 @@
 <Project>
   <PropertyGroup>
+    <IlcUseConservativeGc>true</IlcUseConservativeGc>
+
     <OutputType>Exe</OutputType>
 
     <BundleDir>$([MSBuild]::NormalizeDirectory('$(OutDir)', 'publish'))</BundleDir>

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

@@ -272,6 +272,9 @@ The .NET Foundation licenses this file to you under the MIT license.
       <IlcArg Include="--resilient" />
       <IlcArg Include="@(UnmanagedEntryPointsAssembly->'--generateunmanagedentrypoints:%(Identity)')" />
 
+      <IlcArg Condition="'$(IlcUseConservativeGc)' == 'true'" Include="--runtimeopt:gcConservative=1" />
+      <IlcArg Condition="'$(IlcUseConservativeGc)' == 'true'" Include="--noprecisegc" />
+
       <IlcArg Condition="$(IlcDisableReflection) == 'true'" Include="--feature:System.Reflection.IsReflectionExecutionAvailable=false" />
 
       <!-- Configure LINQ expressions - disable Emit everywhere -->

src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs

@@ -495,7 +495,15 @@ private void PublishCode()
             _methodCodeNode.InitializeColdFrameInfos(_coldFrameInfos);
 #endif
             _methodCodeNode.InitializeDebugEHClauseInfos(debugEHClauseInfos);
-            _methodCodeNode.InitializeGCInfo(_gcInfo);
+
+#if !READYTORUN
+            if ((_compilation._compilationOptions & RyuJitCompilationOptions.NoPreciseGc) == 0
+                // GC info is necessary to unwind reverse P/invokes and cannot be stripped
+                || _methodCodeNode.Method.IsUnmanagedCallersOnly)
+#endif
+            {
+                _methodCodeNode.InitializeGCInfo(_gcInfo);
+            }
             _methodCodeNode.InitializeEHInfo(ehInfo);
 
             _methodCodeNode.InitializeDebugLocInfos(_debugLocInfos);

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/CompilationBuilder.Aot.cs

@@ -25,6 +25,7 @@ public partial class CompilationBuilder
         protected SecurityMitigationOptions _mitigationOptions;
         protected bool _dehydrate;
         protected bool _useDwarf5;
+        protected bool _isPreciseGc = true;
 
         partial void InitializePartial()
         {
@@ -122,6 +123,12 @@ public CompilationBuilder UseDwarf5(bool value)
             return this;
         }
 
+        public CompilationBuilder UseGCStackReporting(bool isPrecise)
+        {
+            _isPreciseGc = isPrecise;
+            return this;
+        }
+
         protected PreinitializationManager GetPreinitializationManager()
         {
             if (_preinitializationManager == null)

src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilation.cs

@@ -244,5 +244,6 @@ public enum RyuJitCompilationOptions
         ControlFlowGuardAnnotations = 0x2,
         UseDwarf5 = 0x4,
         UseResilience = 0x8,
+        NoPreciseGc = 0x10,
     }
 }

src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilationBuilder.cs

@@ -123,6 +123,9 @@ public override ICompilation ToCompilation()
             if (_resilient)
                 options |= RyuJitCompilationOptions.UseResilience;
 
+            if (!_isPreciseGc)
+                options |= RyuJitCompilationOptions.NoPreciseGc;
+
             var factory = new RyuJitNodeFactory(_context, _compilationGroup, _metadataManager, _interopStubManager, _nameMangler, _vtableSliceProvider, _dictionaryLayoutProvider, _inlinedThreadStatics, GetPreinitializationManager());
 
             JitConfigProvider.Initialize(_context.Target, jitFlagBuilder.ToArray(), _ryujitOptions, _jitPath);

src/coreclr/tools/aot/ILCompiler/ILCompilerRootCommand.cs

@@ -91,6 +91,8 @@ internal sealed class ILCompilerRootCommand : CliRootCommand
             new("--stacktracedata") { Description = "Emit data to support generating stack trace strings at runtime" };
         public CliOption<bool> MethodBodyFolding { get; } =
             new("--methodbodyfolding") { Description = "Fold identical method bodies" };
+        public CliOption<bool> NoPreciseGc { get; } =
+            new("--noprecisegc") { Description = "Do not generate precise stack GC information" };
         public CliOption<string[]> InitAssemblies { get; } =
             new("--initassembly") { DefaultValueFactory = _ => Array.Empty<string>(), Description = "Assembly(ies) with a library initializer" };
         public CliOption<string[]> FeatureSwitches { get; } =
@@ -202,6 +204,7 @@ public ILCompilerRootCommand(string[] args) : base(".NET Native IL Compiler")
             Options.Add(IlDump);
             Options.Add(EmitStackTraceData);
             Options.Add(MethodBodyFolding);
+            Options.Add(NoPreciseGc);
             Options.Add(InitAssemblies);
             Options.Add(FeatureSwitches);
             Options.Add(RuntimeOptions);

src/coreclr/tools/aot/ILCompiler/Program.cs

@@ -535,6 +535,7 @@ void RunScanner()
                 .UseInstructionSetSupport(instructionSetSupport)
                 .UseBackendOptions(Get(_command.CodegenOptions))
                 .UseMethodBodyFolding(enable: Get(_command.MethodBodyFolding))
+                .UseGCStackReporting(isPrecise: !Get(_command.NoPreciseGc))
                 .UseParallelism(parallelism)
                 .UseMetadataManager(metadataManager)
                 .UseInteropStubManager(interopStubManager)

src/libraries/System.Collections.Immutable/tests/Frozen/FrozenDictionaryTests.cs

@@ -196,6 +196,7 @@ public static IEnumerable<object[]> LookupItems_AllItemsFoundAsExpected_MemberDa
 
         [Theory]
         [MemberData(nameof(LookupItems_AllItemsFoundAsExpected_MemberData))]
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/88628", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
         public void LookupItems_AllItemsFoundAsExpected(int size, IEqualityComparer<TKey> comparer, bool specifySameComparer)
         {
             Dictionary<TKey, TValue> original =

src/tests/nativeaot/Directory.Build.props

@@ -9,5 +9,7 @@
 
     <!-- We expect trimming to be fully enabled in these tests -->
     <EnableAggressiveTrimming>true</EnableAggressiveTrimming>
+
+    <IlcUseConservativeGc>true</IlcUseConservativeGc>
   </PropertyGroup>
 </Project>