Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/roslyn-analyzers #89630

Merged
merged 20 commits into from
Aug 7, 2023
Merged

[main] Update dependencies from dotnet/roslyn-analyzers #89630

merged 20 commits into from
Aug 7, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 28, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20230805.1
  • Date Produced: August 5, 2023 1:19:34 PM UTC
  • Commit: 633ade7a83c2b6918c10035247d93fbe1520463d
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
81a6878 
…uild 20230727.4

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23377.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jul 28, 2023
@lewing lewing requested a review from radical as a code owner July 28, 2023 17:15
@lewing lewing force-pushed the darc-main-85a6f497-d4ac-4076-916f-09908274a169 branch from f75075c to 99a2229 Compare July 28, 2023 17:23
@lewing lewing requested a review from marek-safar as a code owner July 28, 2023 17:36
@build-analysis build-analysis bot mentioned this pull request Jul 28, 2023
Closed
@lewing lewing requested a review from MichalStrehovsky as a code owner July 28, 2023 19:00
@build-analysis build-analysis bot mentioned this pull request Jul 28, 2023
Open
@radical
Fix roslyn analyzer issues
3b1c2c0 
```
/__w/1/s/src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs(71,17): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs(71,55): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs(114,33): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs(136,33): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs(141,33): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/System.Data.Common/src/System/Data/Common/DBCommandBuilder.cs(736,56): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
/__w/1/s/src/libraries/System.Data.Common/src/System/Data/Common/DBCommandBuilder.cs(740,56): error CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2249) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]
```

Remaining:
`/__w/1/s/src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs(168,26): error CA1862: Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]`
@radical
Copy link
Member

radical commented Jul 29, 2023

I fixed some of the analyzer errors. The remaining one is

runtime/src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs

Lines 165 to 169 in 3b1c2c0

[Conditional("DEBUG")]
static partial void DebugTraceKeyValuePair(string keyname, string? keyvalue, Dictionary<string, string>? synonyms)
{
Debug.Assert(keyname == keyname.ToLowerInvariant(), "missing ToLower");

/__w/1/s/src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs(168,26): error CA1862: Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]

dotnet-maestro bot added 2 commits July 29, 2023 12:18
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
dbb6a54 
…uild 20230728.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23378.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ffd9319 
…uild 20230730.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23380.2
@lewing
Copy link
Member

lewing commented Jul 31, 2023 •
edited
Loading

I fixed some of the analyzer errors. The remaining one is

runtime/src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs

Lines 165 to 169 in 3b1c2c0

[Conditional("DEBUG")]
static partial void DebugTraceKeyValuePair(string keyname, string? keyvalue, Dictionary<string, string>? synonyms)
{
Debug.Assert(keyname == keyname.ToLowerInvariant(), "missing ToLower");

/__w/1/s/src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs(168,26): error CA1862: Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862) [/__w/1/s/src/libraries/System.Data.Common/src/System.Data.Common.csproj]

yeah this one would need to be suppressed if we want to keep the intended meaning, there are a lot more errors you'll hit once you fix the current failures though.

@buyaa-n buyaa-n mentioned this pull request Jul 31, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 1, 2023
Closed
dotnet-maestro bot and others added 4 commits August 1, 2023 12:19
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
5dbae01 
…uild 20230731.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23381.2
@buyaa-n
Revert unwanted change
a6c5ed8
@buyaa-n
Merge branch 'darc-main-85a6f497-d4ac-4076-916f-09908274a169' of gith…
d79086d 
…ub.com:dotnet/runtime into darc-main-85a6f497-d4ac-4076-916f-09908274a169
@buyaa-n
Small update
58614b0
@build-analysis build-analysis bot mentioned this pull request Aug 1, 2023
Closed
buyaa-n
buyaa-n approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures unrelated and known

This was referenced Aug 1, 2023
Open
Closed
MichalStrehovsky
MichalStrehovsky approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to /coreclr/tools and /tools look good to me. I'm not looking at any other files.

@buyaa-n buyaa-n requested a review from lewing August 2, 2023 03:49
dotnet-maestro bot and others added 2 commits August 2, 2023 12:21
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
dc95192 
…uild 20230801.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23401.2
@buyaa-n
Fix more warnings caused by bugfix in CA1864
ce2d061
dotnet-maestro bot added 2 commits August 3, 2023 12:19
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
16aaa1d 
…uild 20230802.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23402.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
e9db46b 
…uild 20230803.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23403.2
@buyaa-n buyaa-n mentioned this pull request Aug 4, 2023
Closed
dotnet-maestro bot added 2 commits August 5, 2023 12:17
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
a2f16c3 
…uild 20230804.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23404.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
ca00a3e 
…uild 20230805.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23364.2 -> To Version 3.11.0-beta1.23405.1
@buyaa-n buyaa-n merged commit 8917ca2 into main Aug 7, 2023
@buyaa-n buyaa-n deleted the darc-main-85a6f497-d4ac-4076-916f-09908274a169 branch August 7, 2023 16:57
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bellarmine-Head Bellarmine-Head Bellarmine-Head left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@radical radical Awaiting requested review from radical

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@tarekgh tarekgh Awaiting requested review from tarekgh

@lewing lewing Awaiting requested review from lewing

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@radical @lewing @Bellarmine-Head @tarekgh @MichalStrehovsky @buyaa-n