Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new analyzer CA1868: 'Unnecessary call to 'Contains' for sets' and fix findings #89652

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Enable new analyzer CA1868: 'Unnecessary call to 'Contains' for sets' and fix findings #89652

merged 3 commits into from
Jul 29, 2023

Commits on Jul 28, 2023

  1. Enable new analyzer CA1868 and fix findings 

    The new analyzer CA1868: 'Unnecessary call to 'Contains' for sets'
checks when an Add or Remove is guarded by Contains.

This commit removes these calls to Contains.
    @mpidash
    mpidash committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0b9c146 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @mpidash
    mpidash committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6264127 View commit details
    Browse the repository at this point in the history

  3. Disable CA1868 for tests

    @mpidash
    mpidash committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2e378e1 View commit details
    Browse the repository at this point in the history