Enable new analyzer CA1868: 'Unnecessary call to 'Contains' for sets' and fix findings #89652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new analyzer CA1868: 'Unnecessary call to 'Contains' for sets' checks when an Add or Remove is guarded by Contains. This commit removes these calls to Contains.
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsSee dotnet/roslyn-analyzers#6767 and #85490.
|
stephentoub
reviewed
Jul 28, 2023
| @@ -483,6 +483,9 @@ dotnet_diagnostic.CA1863.severity = suggestion | |||
| # CA1864: Prefer the 'IDictionary.TryAdd(TKey, TValue)' method | |||
| dotnet_diagnostic.CA1864.severity = warning | |||
|
|
|||
| # CA1868: Unnecessary call to 'Contains' for sets | |||
| dotnet_diagnostic.CA1868.severity = warning | |||
There was a problem hiding this comment.
Can you add a corresponding entry to the .test.globalconfig file? That one would be at level none.
stephentoub
reviewed
Jul 28, 2023
Comment on lines
188
to
190
| if (!candidates.Add(candidatePart)) | ||
| { | ||
| alreadyProcessed = true; |
There was a problem hiding this comment.
alreadyProcessed |= !candidates.Add(candidatePart);?
This was referenced Jul 29, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/roslyn-analyzers#6767 and #85490.