-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor] Add basic ICU tests #89771
[Blazor] Add basic ICU tests #89771
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
For a follow-up PR:
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Details
For a follow-up PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this needs a review after your other PR, that splits the tests, is merged.
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs
Outdated
Show resolved
Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/AssetsComputingHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 In a follow up we should expand the tests, and maybe try to re-use the ones we have for test-main.js . I will fix up our API to facilitate that.
Fixes #89406.
First merge #89926, then this one.
LoadAllICUData
->LoadFullICUData
. "All" could mean "all data files" while we meant to say "data with full locales support".ShouldFilterCandidate
).For a follow-up PR: #90018