Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blazor] Add basic ICU tests #89771

Merged
merged 22 commits into from
Aug 9, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Aug 1, 2023

Fixes #89406.
First merge #89926, then this one.

  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while we meant to say "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR: #90018

@ilonatommy ilonatommy added this to the 8.0.0 milestone Aug 1, 2023
@ilonatommy ilonatommy requested a review from maraf August 1, 2023 12:02
@ilonatommy ilonatommy self-assigned this Aug 1, 2023
@ghost
Copy link

ghost commented Aug 1, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while it means "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR:

  • fixing the problem with hashing when custom ICU file is used in Blazor.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, area-Build-mono

Milestone: 8.0.0

@ghost
Copy link

ghost commented Aug 1, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Unblock Blazor WBT ICU assets checks.
  2. Rename internal LoadAllICUData -> LoadFullICUData. "All" could mean "all data files" while it means "data with full locales support".
  3. Fixing the problem of loading all ICU assets to runtime pack in Hybrid or Full icu mode (see ShouldFilterCandidate).

For a follow-up PR:

  • fixing the problem with hashing when custom ICU file is used in Blazor.
Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, area-Build-mono

Milestone: 8.0.0

@ilonatommy ilonatommy closed this Aug 2, 2023
@ilonatommy ilonatommy reopened this Aug 2, 2023
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this needs a review after your other PR, that splits the tests, is merged.

@ilonatommy ilonatommy requested a review from radical August 7, 2023 10:56
@ilonatommy ilonatommy requested a review from radical August 8, 2023 09:37
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 In a follow up we should expand the tests, and maybe try to re-use the ones we have for test-main.js . I will fix up our API to facilitate that.

@ilonatommy ilonatommy merged commit 13c8230 into dotnet:main Aug 9, 2023
30 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] icu build related improvements
2 participants