[main] Update dependencies from dotnet/runtime #34522

dotnet-maestro · 2023-08-08T18:52:04Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20230813.2
Date Produced: August 13, 2023 3:38:16 PM UTC
Commit: af651f48d07c87c94e1225859e63e919719b687b
Branch: refs/heads/main

Updates:
- Microsoft.Extensions.DependencyModel: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.Extensions.FileSystemGlobbing: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.Extensions.Logging.Console: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NET.HostModel: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NET.ILLink.Tasks: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NETCore.App.Ref: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NETCore.Platforms: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.CodeDom: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.Reflection.MetadataLoadContext: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.Resources.Extensions: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.Security.Cryptography.ProtectedData: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.ServiceProcess.ServiceController: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- System.Text.Encoding.CodePages: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-rc.1.23408.3 to 8.0.0-rc.1.23413.2
- Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport: from 8.0.0-rc.1.23402.3 to 8.0.0-rc.1.23411.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport: from 8.0.0-rc.1.23402.3 to 8.0.0-rc.1.23411.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)

…0808.4 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23408.4

…0808.8 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23408.8

dotnet-maestro · 2023-08-08T23:05:16Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…0808.14 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23408.14

anatawa12 · 2023-08-09T04:34:17Z

Tests.GivenThatWeWantToBuildAComServerLibrary.It_fails_to_embed_clsid_when_not_on_windows

It looks this test failure is expected failure with dotnet/runtime#89303. I'm going to fix the test in #34394.

Microsoft.DotNet.ShellShim.Tests.AppHostShellShimMakerTests.GivenNonWindowsMachineWhenCallWithWpfDllItCanCreateShimWithoutThrow

It looks this test failure is AppHostShellShimMaker's bug. AppHostShellShimMaker sets windowsGraphicalUserInterface true even if AppHost is not PE file. AppHostWriter throws exception in this case.
I'm going to create another pull request to fix AppHostShellShimMaker.: #34534

elinor-fung · 2023-08-09T05:02:18Z

For the GivenThatWeWantToBuildAComServerLibrary.It_fails_when_typelib_is_invalid failure on the Windows leg, I think we should update ComHost in runtime to just check for the byte count being 0 and throw throw InvalidTypeLibraryException - it was relying on the Win32 UpdateResource function failing with E_INVALIDARG for that case (which will now never happen): https://github.com/dotnet/runtime/blob/main/src/installer/managed/Microsoft.NET.HostModel/ComHost/ComHost.cs#L70-L73

…0808.18 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23408.18

…0809.1 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23409.1

elinor-fung · 2023-08-09T21:18:50Z

WasmBuildIntegrationTest failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=368839&view=ms.vss-test-web.build-test-results-tab&runId=7817070&resultId=103322&paneView=debug

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIntegrationTest.Build_SatelliteAssembliesAreCopiedToBuildOutput [FAIL]
  Expected collection to be empty because the generated manifest should match the expected baseline.
  
  If the difference in baselines is expected, please re-generate the baselines.
  Start by ensuring you're dogfooding the SDK from the current branch (dotnet --version should be '*.0.0-dev').
      If you're not on the dogfood sdk, from the root of the repository run:
          1. dotnet clean
          2. .\restore.cmd or ./restore.sh
          3. .\build.cmd ./build.sh
          4. .\eng\dogfood.cmd or . ./eng/dogfood.sh
  
  Then, using the dogfood SDK run the .\src\RazorSdk\update-test-baselines.ps1 script.
  
  , but found {"
  ==================================================
  
  For ${ProjectPath}\blazorwasm\bin\Debug\${Tfm}\wwwroot\_framework\es-ES\classlibrarywithsatelliteassemblies.resources.wasm:
  
  Expected manifest OriginalItemSpec of ${ProjectPath}\blazorwasm\obj\Debug\${Tfm}\webcil\classlibrarywithsatelliteassemblies.resources.wasm but found ${ProjectPath}\blazorwasm\obj\Debug\${Tfm}\webcil\es-ES\classlibrarywithsatelliteassemblies.resources.wasm.
  
  =================================================="}.
  Stack Trace:
       at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
       at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
       at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
       at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
       at FluentAssertions.Execution.GivenSelector`1.FailWith(String message, Object[] args)
       at FluentAssertions.Collections.GenericCollectionAssertions`3.BeEmpty(String because, Object[] becauseArgs)
    /_/src/Tests/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselineComparer.cs(104,0): at Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsBaselineComparer.CompareGroup(String group, StaticWebAsset[] manifestAssets, StaticWebAsset[] expectedAssets)
    /_/src/Tests/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselineComparer.cs(60,0): at Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsBaselineComparer.AssertManifest(StaticWebAssetsManifest expected, StaticWebAssetsManifest manifest)
    /_/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs(243,0): at Microsoft.NET.Sdk.Razor.Tests.AspNetSdkBaselineTest.AssertManifest(StaticWebAssetsManifest manifest, StaticWebAssetsManifest expected, String suffix, String runtimeIdentifier, String name)
    /_/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs(534,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIntegrationTest.Build_SatelliteAssembliesAreCopiedToBuildOutput()

I'm guessing this is from dotnet/runtime#89600 and it is expected / the baselines need to be updated?

@maraf / @radical could you take a look?

…0809.6 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23409.6

elinor-fung · 2023-08-10T00:36:49Z

The failures related to cross-platform resource updater have been addressed (thanks, @anatawa12).

Aside from #34522 (comment), there a bunch of other BlazorWebAssembly test failures now - for example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=368960&view=ms.vss-test-web.build-test-results-tab&runId=7821590&resultId=103263&paneView=debug

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIntegrationTest.Publish_WithBlazorWebAssemblyLoadAllGlobalizationData_SetsGlobalizationMode [FAIL]
  Expected dictionary {["icudt.dat"] = "sha256-tO5O5YzMTVSaKBboxAqezOQL9ewmupzV2JrB5Rkc8a4="} to contain key "icudt_EFIGS.dat".
  Stack Trace:
       at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
       at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
       at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
       at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
       at FluentAssertions.Collections.GenericDictionaryAssertions`4.ContainKeys(IEnumerable`1 expected, String because, Object[] becauseArgs)
       at FluentAssertions.Collections.GenericDictionaryAssertions`4.ContainKey(TKey expected, String because, Object[] becauseArgs)
    /_/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmBuildIntegrationTest.cs(474,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIntegrationTest.Publish_WithBlazorWebAssemblyLoadAllGlobalizationData_SetsGlobalizationMode()

@ilonatommy would this be related to the hybrid/full icu changes in dotnet/runtime#89771? Could you take a look?

…0809.16 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23409.16

…0809.17 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23409.17

ilonatommy · 2023-08-10T10:59:45Z

@ilonatommy would this be related to the hybrid/full icu changes in dotnet/runtime#89771? Could you take a look?

You are right, it is related. After that PR the expected behavior changed (less ICU files is loaded for each globalization option). Build_SatelliteAssembliesAreCopiedToBuildOutput failure is connected with ICU as well:

The following expected assets weren't found in the manifest: 
${ProjectPath}\\blazorwasm\\obj\\Debug\\${Tfm}\\compressed\\_framework\\icudt_hybrid.dat.gz
\t${ProjectPath}\\blazorwasm\\obj\\Debug\\${Tfm}\\compressed\\_framework\\icudt.dat.gz
If the difference in baselines is expected, please re-generate the baselines
Start by ensuring you're dogfooding the SDK from the current branch (dotnet --version should be '*.0.0-dev').
If you're not on the dogfood sdk, from the root of the repository run:
        1. dotnet clean
        2. .\\restore.cmd or ./restore.sh
        3. .\\build.cmd ./build.sh
        4. .\\eng\\dogfood.cmd or . ./eng/dogfood.sh
Then, using the dogfood SDK run the .\\src\\RazorSdk\\update-test-baselines.ps1 script.</pre><pre>   at Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsBaselineComparer.&lt;CompareAssetCounts&gt;g__ThrowAssetCountMismatchError|6_0(StaticWebAsset[] manifestAssets, StaticWebAsset[] expectedAssets) in C:\Users\itomkowicz\source\repos\sdk-fork\src\Tests\Microsoft.NET.Sdk.Razor.Tests\StaticWebAssetsBaselineComparer.cs:line 156

…o full nor hybrid file.

…ards - no full nor hybrid file." This reverts commit 1a7fbda.

…0810.9 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23410.9

…0810.11 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23410.11

…0810.15 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23410.15

v-wuzhai · 2023-08-11T09:54:50Z

@ilonatommy @marcpopMSFT I tried to update the baselines d043962 but still had some other tests fail, could you take a look?

ilonatommy · 2023-08-11T13:19:04Z

but still had some other tests fail, could you take a look?

Looks like this is the PR: dotnet/runtime#89754 @radical, do you know how we can add workload installation command to the tests?

Expected command to pass but it did not.
 File Name: /tmp/helix/working/B57109C4/p/d/dotnet
 Arguments: msbuild /t:Publish /private/tmp/helix/working/B57109C4/w/AFE809E0/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj /restore
 Exit Code: 1
  StdOut:
 MSBuild version 17.6.1+8ffc3fe3d for .NET
     Determining projects to restore...
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools 
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore

elinor-fung · 2023-08-11T15:28:47Z

There's also some native AOT publish test failures on macOS only. Looks like the test is not finding the symbol file.

@agocke I think this is from dotnet/runtime#89358 - should tests be looking for .dsym instead of .dwarf on macOS now?

https://dev.azure.com/dnceng-public/public/_build/results?buildId=370794&view=ms.vss-test-web.build-test-results-tab&runId=7869216&resultId=103204&paneView=debug

Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_app_runs_in_release_with_no_config_when_PublishAot_is_enabled(targetFramework: "net8.0") [FAIL]
   Expected boolean to be true, but found False.
     Stack Trace:
        at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
        at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
        at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
        at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
        at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
        at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
        at FluentAssertions.Primitives.BooleanAssertions`1.BeTrue(String because, Object[] becauseArgs)
     /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs(213,0): at Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAot_app_runs_in_release_with_no_config_when_PublishAot_is_enabled(String targetFramework)
        at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs

Lines 212 to 213 in b08a998

    
           // There should be a debug file 
        
           File.Exists(publishedDebugFile).Should().BeTrue();

sdk/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs

Lines 994 to 996 in b08a998

    
           else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) 
        
           { 
        
               return ".dwarf";

agocke · 2023-08-11T15:56:10Z

Yes, sorry, this was me. Fixing.

radical · 2023-08-11T16:59:02Z

but still had some other tests fail, could you take a look?

Looks like this is the PR: dotnet/runtime#89754 @radical, do you know how we can add workload installation command to the tests?

Expected command to pass but it did not.
 File Name: /tmp/helix/working/B57109C4/p/d/dotnet
 Arguments: msbuild /t:Publish /private/tmp/helix/working/B57109C4/w/AFE809E0/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj /restore
 Exit Code: 1
  StdOut:
 MSBuild version 17.6.1+8ffc3fe3d for .NET
     Determining projects to restore...
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools 
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore

These tests set InvariantGlobalization=true. Is that expected to work without the workload?
cc @javiercn

radical · 2023-08-11T17:57:10Z

but still had some other tests fail, could you take a look?

Looks like this is the PR: dotnet/runtime#89754 @radical, do you know how we can add workload installation command to the tests?

Expected command to pass but it did not.
 File Name: /tmp/helix/working/B57109C4/p/d/dotnet
 Arguments: msbuild /t:Publish /private/tmp/helix/working/B57109C4/w/AFE809E0/e/testExecutionDirectory/Publish_WithI---129F25F8_2/blazorwasm-minimal.csproj /restore
 Exit Code: 1
  StdOut:
 MSBuild version 17.6.1+8ffc3fe3d for .NET
     Determining projects to restore...
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools 
     /tmp/helix/working/B57109C4/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore

These tests set InvariantGlobalization=true. Is that expected to work without the workload? cc @javiercn

I will open a PR for runtime to fix this.

marcpopMSFT · 2023-08-11T19:00:11Z

We already have workload installs in some of the legs using a automated rollback file. Does that just need to be expanded to more legs?

radical · 2023-08-11T21:46:31Z

We already have workload installs in some of the legs using a automated rollback file. Does that just need to be expanded to more legs?

No, this was a regression fixed in dotnet/runtime#90432 .

radical · 2023-08-11T21:54:49Z

Looking at the failures, there is one that is different, and should not be due to wasm changes (log):

�[31;1m    Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishAnAotApp.NativeAotSharedLib_only_runs_when_switch_is_enabled(targetFramework: "net8.0") [FAIL]
�[m�[37m      Expected command to pass but it did not.
�[m�[37m      File Name: /tmp/helix/working/ACA70954/p/d/dotnet
�[m�[37m      Arguments: msbuild /t:Publish /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/AotSharedLibraryPublish.csproj /restore
�[m�[37m      Exit Code: 1
�[m�[37m      StdOut:
�[m�[37m      MSBuild version 17.6.1+8ffc3fe3d for .NET
�[m�[37m        Determining projects to restore...
�[m�[37m        Restored /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/AotSharedLibraryPublish.csproj (in 362 ms).
�[m�[37m      /tmp/helix/working/ACA70954/p/d/sdk/8.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/AotSharedLibraryPublish.csproj]
�[m�[37m        AotSharedLibraryPublish -> /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/bin/Debug/net8.0/osx-x64/AotSharedLibraryPublish.dll
�[m�[37m        Generating native code
�[m�[37m        AotSharedLibraryPublish -> /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/bin/Debug/net8.0/osx-x64/publish/
�[m�[37m      /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.0-rc.1.23410.15/build/Microsoft.NETCore.Native.Publish.targets(117,5): error MSB3025: The source file "bin/Debug/net8.0/osx-x64/native/AotSharedLibraryPublish.dylib.dsym" is actually a directory.  The "Copy" task does not support copying directories. [/private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/AotSharedLibraryPublish.csproj]
�[m�[37m      StdErr:

elinor-fung · 2023-08-11T22:06:31Z

Actual error from publish is: /private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.0-rc.1.23410.15/build/Microsoft.NETCore.Native.Publish.targets(117,5): error MSB3025: The source file "bin/Debug/net8.0/osx-x64/native/AotSharedLibraryPublish.dylib.dsym" is actually a directory. The "Copy" task does not support copying directories. [/private/tmp/helix/working/ACA70954/w/929C0880/e/testExecutionDirectory/NativeAotShar---BB97B19D_2/AotSharedLibraryPublish/AotSharedLibraryPublish.csproj]

@agocke - looks like it is also from dotnet/runtime#89358. I think it needs a fix in runtime?

radical · 2023-08-12T07:20:12Z

dotnet-runtime-official build is broken, OneLocBuild is failing:

[03:30:28 ERR] Localization build failed.
System.AggregateException: One or more errors occurred. ---> System.Exception: Running LSBuild failed with exit codes '8'.
   at Microsoft.Localization.XLoc.Build.Local.ResponseManager.ExecuteAll(IDictionary`2 lsBuildPaths, CancellationToken cancelToken) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\ResponseManager.cs:line 139
   at Microsoft.Localization.XLoc.Build.Local.LSBuild.RunBuild(Project project, Int64 index, CancellationToken cancellationToken) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\LSBuild.cs:line 191
   at Microsoft.Localization.XLoc.Build.Local.LSBuild.<>c__DisplayClass14_0.<Execute>b__0(Project project, ParallelLoopState state, Int64 index) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\LSBuild.cs:line 103
   at System.Threading.Tasks.Parallel.<>c__DisplayClass17_0`1.<ForWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object <p0>)
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Parallel.ForWorker[TLocal](Int32 fromInclusive, Int32 toExclusive, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Func`4 bodyWithLocal, Func`1 localInit, Action`1 localFinally)
   at System.Threading.Tasks.Parallel.ForEachWorker[TSource,TLocal](IEnumerable`1 source, ParallelOptions parallelOptions, Action`1 body, Action`2 bodyWithState, Action`3 bodyWithStateAndIndex, Func`4 bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit, Action`1 localFinally)
   at System.Threading.Tasks.Parallel.ForEach[TSource](IEnumerable`1 source, Action`3 body)
   at Microsoft.Localization.XLoc.Build.Local.LSBuild.Execute(LocArtifact artifact, Settings settings, CancellationToken cancellationToken) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\LSBuild.cs:line 111
   at Microsoft.Localization.XLoc.Program.Execute(IEnumerable`1 artifactPaths, Boolean isLocalBuild) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Program.cs:line 160
   at Microsoft.Localization.XLoc.Program.Main(String[] args) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Program.cs:line 114
---> (Inner Exception #0) System.Exception: Running LSBuild failed with exit codes '8'.
   at Microsoft.Localization.XLoc.Build.Local.ResponseManager.ExecuteAll(IDictionary`2 lsBuildPaths, CancellationToken cancelToken) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\ResponseManager.cs:line 139
   at Microsoft.Localization.XLoc.Build.Local.LSBuild.RunBuild(Project project, Int64 index, CancellationToken cancellationToken) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\LSBuild.cs:line 191
   at Microsoft.Localization.XLoc.Build.Local.LSBuild.<>c__DisplayClass14_0.<Execute>b__0(Project project, ParallelLoopState state, Int64 index) in D:\Repos\ceapex\CEINTL\SWSys-Build-XLoc\src\XLoc\Build\Local\LSBuild.cs:line 103
   at System.Threading.Tasks.Parallel.<>c__DisplayClass17_0`1.<ForWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object <p0>)<---

lewing · 2023-08-12T18:18:02Z

OneLoc started failing in this range dotnet/runtime@786b987...64a6771

lewing · 2023-08-12T18:28:45Z

OneLoc started failing in this range dotnet/runtime@786b987...64a6771

my guess is that it is one of the arcade bumps in dotnet/runtime#90014 either one of the xliff updates like dotnet/xliff-tasks@a61cdec...d3553ca
or dotnet/arcade#13938 but I'm not familiar with this tooling.

cc @mmitche @NikolaMilosavljevic

…0813.2 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0 From Version 8.0.0-rc.1.23408.3 -> To Version 8.0.0-rc.1.23413.2 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-rc.1.23402.3 -> To Version 8.0.0-rc.1.23411.2 (parent: Microsoft.NETCore.App.Runtime.win-x64

dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Aug 8, 2023

anatawa12 mentioned this pull request Aug 9, 2023

fix AppHostShellShimMaker to make it work well with Crossplatform ResourceUpdater #34534

Merged

anatawa12 mentioned this pull request Aug 9, 2023

make it throw InvalidTypeLibraryException if type library is empty file dotnet/runtime#90220

Merged

dotnet-maestro bot and others added 2 commits August 9, 2023 12:40

Update tests for embedding clsidmap in comhost

964a311

dotnet-maestro bot and others added 3 commits August 10, 2023 01:41

Fix ICU tests.

67aabe9

ilonatommy requested a review from a team as a code owner August 10, 2023 10:55

ilonatommy and others added 3 commits August 10, 2023 13:22

Re-generate baseline. Reason: the default app has only ICU shards - n…

1a7fbda

…o full nor hybrid file.

Revert "Re-generate baseline. Reason: the default app has only ICU sh…

7220f03

…ards - no full nor hybrid file." This reverts commit 1a7fbda.

build-analysis bot mentioned this pull request Aug 11, 2023

File used by another process #33956

Closed

dotnet-maestro bot and others added 2 commits August 11, 2023 02:38

Try to update Blazor baselines

d043962

v-wuzhai requested a review from marcpopMSFT August 11, 2023 07:06

Change symbol suffix from .dwarf to .dsym

6e999c9

marcpopMSFT mentioned this pull request Aug 11, 2023

[main] Update dependencies from dotnet/sdk dotnet/installer#17118

Merged

radical mentioned this pull request Aug 11, 2023

[wasm] Fix builds for blazor app + InvariantGlobalization=true dotnet/runtime#90432

Merged

elinor-fung mentioned this pull request Aug 11, 2023

Fix condition for setting if symbol is a file in native AOT publish targets dotnet/runtime#90438

Merged

lewing mentioned this pull request Aug 12, 2023

[main] Update dependencies from dotnet/arcade dotnet/arcade-services dotnet/arcade#13938

Merged

lewing added the Blocked Issue is blocked on an external dependency label Aug 12, 2023

lewing mentioned this pull request Aug 12, 2023

Official build is failing on OneLocBuild step dotnet/runtime#90466

Closed

lewing added the release blocking label Aug 13, 2023

akoeplinger approved these changes Aug 13, 2023

View reviewed changes

dotnet-maestro bot merged commit fc2d7e0 into main Aug 13, 2023
19 checks passed

dotnet-maestro bot deleted the darc-main-039f5186-d6b1-4109-985c-47a35e3f6316 branch August 13, 2023 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #34522

[main] Update dependencies from dotnet/runtime #34522

dotnet-maestro bot commented Aug 8, 2023 •

edited

Loading

dotnet-maestro bot commented Aug 8, 2023

anatawa12 commented Aug 9, 2023 •

edited

Loading

elinor-fung commented Aug 9, 2023

elinor-fung commented Aug 9, 2023

elinor-fung commented Aug 10, 2023

ilonatommy commented Aug 10, 2023

v-wuzhai commented Aug 11, 2023

ilonatommy commented Aug 11, 2023

elinor-fung commented Aug 11, 2023 •

edited

Loading

agocke commented Aug 11, 2023

radical commented Aug 11, 2023

radical commented Aug 11, 2023

marcpopMSFT commented Aug 11, 2023

radical commented Aug 11, 2023

radical commented Aug 11, 2023

elinor-fung commented Aug 11, 2023 •

edited

Loading

radical commented Aug 12, 2023

lewing commented Aug 12, 2023

lewing commented Aug 12, 2023 •

edited

Loading

[main] Update dependencies from dotnet/runtime #34522

[main] Update dependencies from dotnet/runtime #34522

Conversation

dotnet-maestro bot commented Aug 8, 2023 • edited Loading

From https://github.com/dotnet/runtime

Coherency Updates

dotnet-maestro bot commented Aug 8, 2023

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

anatawa12 commented Aug 9, 2023 • edited Loading

elinor-fung commented Aug 9, 2023

elinor-fung commented Aug 9, 2023

elinor-fung commented Aug 10, 2023

ilonatommy commented Aug 10, 2023

v-wuzhai commented Aug 11, 2023

ilonatommy commented Aug 11, 2023

elinor-fung commented Aug 11, 2023 • edited Loading

agocke commented Aug 11, 2023

radical commented Aug 11, 2023

radical commented Aug 11, 2023

marcpopMSFT commented Aug 11, 2023

radical commented Aug 11, 2023

radical commented Aug 11, 2023

elinor-fung commented Aug 11, 2023 • edited Loading

radical commented Aug 12, 2023

lewing commented Aug 12, 2023

lewing commented Aug 12, 2023 • edited Loading

dotnet-maestro bot commented Aug 8, 2023 •

edited

Loading

anatawa12 commented Aug 9, 2023 •

edited

Loading

elinor-fung commented Aug 11, 2023 •

edited

Loading

elinor-fung commented Aug 11, 2023 •

edited

Loading

lewing commented Aug 12, 2023 •

edited

Loading