-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Enabled tests failing previously on fullaot #90280
Conversation
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Signed-off-by: Vlad <vladionescu1399@gmail.com>
Signed-off-by: Vlad <vladionescu1399@gmail.com>
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let us know when you get the green CI. Also, make sure to close related issues when this PR is merged, if they are fully resolved.
We should verify the passing tests in the log files before merging. |
/azp list |
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
The enabled tests have passed on apple mobile platforms according to the CI status and logs. There are failed library tests which shouldn't be related. |
@LeVladIonescu @kotlarmilos could you please double check if the tests reported in #70492 have been enabled? As I noted in the description of the issue, to enabling building the tests it was also required to adapt the: I am asking this as this PR does not seem to include such change: https://github.com/LeVladIonescu/runtime_fork/blob/7cd6d011ac679dbdec44268a5571ecbfd7f864b2/src/tests/JIT/Directed/callconv/Directory.Build.props#L5 |
That is right. These tests haven't been executed on a device, so I will try to enable them in #90421. |
Related to #57350 and #70492.