Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Enabled tests failing previously on fullaot #90280

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

LeVladIonescu
Copy link
Contributor

Related to #57350 and #70492.

Vlad - Alexandru Ionescu and others added 5 commits July 26, 2023 15:08
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>
Signed-off-by: Vlad <vladionescu1399@gmail.com>
Signed-off-by: Vlad <vladionescu1399@gmail.com>
@LeVladIonescu
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let us know when you get the green CI. Also, make sure to close related issues when this PR is merged, if they are fully resolved.

@SamMonoRT
Copy link
Member

We should verify the passing tests in the log files before merging.

@LeVladIonescu
Copy link
Contributor Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@LeVladIonescu
Copy link
Contributor Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
Copy link
Member

The enabled tests have passed on apple mobile platforms according to the CI status and logs. There are failed library tests which shouldn't be related.

@SamMonoRT
Copy link
Member

Should close #70492 and #57350 when this PR is merged. Want to make sure fullaot passes too once #86324 is fixed. Likely we will not backport a fix to that failing lane in RC1, so should be good to go ahead.

@kotlarmilos kotlarmilos merged commit 4c2f1b6 into dotnet:main Aug 11, 2023
139 of 152 checks passed
@ivanpovazan
Copy link
Member

ivanpovazan commented Aug 11, 2023

@LeVladIonescu @kotlarmilos could you please double check if the tests reported in #70492 have been enabled?

As I noted in the description of the issue, to enabling building the tests it was also required to adapt the: src/tests/JIT/Directed/callconv/Directory.Build.props file in order to enable building the tests for Mono.

I am asking this as this PR does not seem to include such change: https://github.com/LeVladIonescu/runtime_fork/blob/7cd6d011ac679dbdec44268a5571ecbfd7f864b2/src/tests/JIT/Directed/callconv/Directory.Build.props#L5

@kotlarmilos
Copy link
Member

kotlarmilos commented Aug 11, 2023

That is right. These tests haven't been executed on a device, so I will try to enable them in #90421.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants