Fix PortableRuntimeIdentifierGraph.json not found during runtime repo source build #90695
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/backport to release/8.0-rc1 |
|
Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5886760639 |
| <!-- Keep in sync with outputs defined in Microsoft.NETCore.Platforms.csproj. --> | ||
| <BundledRuntimeIdentifierGraphFile>$([MSBuild]::NormalizePath('$(ArtifactsBinDir)', 'Microsoft.NETCore.Platforms', 'runtime.json'))</BundledRuntimeIdentifierGraphFile> | ||
| <BundledRuntimeIdentifierGraphFile Condition="!Exists('$(BundledRuntimeIdentifierGraphFile)')">$([MSBuild]::NormalizePath('$(LibrariesProjectRoot)', 'Microsoft.NETCore.Platforms', 'src', 'runtime.json'))</BundledRuntimeIdentifierGraphFile> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
We've added these lines so the build SDK would know how the rid being built fits in the graph.
I'd be surprised if we can just remove them, as that would mean they were not needed.
There was a problem hiding this comment.
Doesn't the SDK now add the distro specific RID into the graph? cc @dsplaisted
There was a problem hiding this comment.
Yes, the SDK that gets built has the non-portable rid added to it.
That's not what these lines are for: they are for making the SDK that is during the build (for example: a portable Microsoft SDK) know the non-portable rid.
Fix build errors after dotnet/runtime#90695.
|
A consequence of this is the The rid is then known by the output SDK, so the next build (for the same rid, using that source-built SDK) does include a Afaik, this |
ghost
locked as resolved and limited conversation to collaborators
Fixes dotnet/source-build#3592
Will need to go to rc1 as well
Since the full RID graph isn't supposed to be updated any more, stop setting the BundledRuntimeIdentifierGraphFile property, which is currently breaking source-build bootstrapping scenarios.