Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Reverted the change in IsInstanceOfException #90867

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[NativeAOT] Reverted the change in IsInstanceOfException #90867

merged 2 commits into from
Aug 21, 2023

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Aug 21, 2023

Fixes: #90848

@ghost ghost assigned VSadov Aug 21, 2023
@ghost
Copy link

ghost commented Aug 21, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #90848

Author: VSadov
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@VSadov VSadov marked this pull request as ready for review August 21, 2023 20:42
jkotas
jkotas approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit a2df89f into dotnet:main Aug 21, 2023
@VSadov
Copy link
Member Author

VSadov commented Aug 21, 2023

Thanks!

@VSadov
Copy link
Member Author

VSadov commented Aug 21, 2023 •
edited
Loading

My thoughts on whether we need to backport this is that it is ok to be a 9.0 fix only:

  • This affects a corner case scenario when catch clause is used with irregular types (arrays, interfaces,..). It would require writing IL directly.
  • This is an assert-only bug. Everything works correctly in Release.

@VSadov VSadov deleted the IsInstOfException branch August 21, 2023 23:20
@VSadov VSadov mentioned this pull request Aug 21, 2023
Open
@jkotas
Copy link
Member

jkotas commented Aug 21, 2023

I agree

@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@VSadov VSadov

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIT test GenericCatchInterfaceProgram fails in Checked NativeAOT
2 participants
@VSadov @jkotas