Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Enable System.IO.Hashing tests on ios and disable them on tvos #90984

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

ivanpovazan
Copy link
Member

As reported in: #90499 System.IO.Hashing.Tests.Crc32Tests are failing on tvos-arm64 as part of the runtime-extra-platforms pipeline.

Due to the facts that:

  • I was not able to reproduce the reported failure locally
  • The crash log does not include enough information to demystify what is causing the crash
  • And by verifying that the tests are passing on iOS devices

This PR disables running System.IO.Hashing libraries tests on tvos and enables running them on ios platforms, which contributes towards having a green CI by keeping the same test coverage on iOS-like platforms.


Fixes: #90499

@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

As reported in: #90499 System.IO.Hashing.Tests.Crc32Tests are failing on tvos-arm64 as part of the runtime-extra-platforms pipeline.

Due to the facts that:

  • I was not able to reproduce the reported failure locally
  • The crash log does not include enough information to demystify what is causing the crash
  • And by verifying that the tests are passing on iOS devices

This PR disables running System.IO.Hashing libraries tests on tvos and enables running them on ios platforms, which contributes towards having a green CI by keeping the same test coverage on iOS-like platforms.


Fixes: #90499

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

As reported in: #90499 System.IO.Hashing.Tests.Crc32Tests are failing on tvos-arm64 as part of the runtime-extra-platforms pipeline.

Due to the facts that:

  • I was not able to reproduce the reported failure locally
  • The crash log does not include enough information to demystify what is causing the crash
  • And by verifying that the tests are passing on iOS devices

This PR disables running System.IO.Hashing libraries tests on tvos and enables running them on ios platforms, which contributes towards having a green CI by keeping the same test coverage on iOS-like platforms.


Fixes: #90499

Author: ivanpovazan
Assignees: ivanpovazan
Labels:

area-Infrastructure-libraries, area-Infrastructure-mono

Milestone: -

@kotlarmilos
Copy link
Member

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivanpovazan
Copy link
Member Author

@ivanpovazan
Copy link
Member Author

@kotlarmilos @steveisok not sure whether this should be backported for having a cleaner CI builds on .NET8 branches

@kotlarmilos
Copy link
Member

It is an infra change without risk, so I think we should backport it.

@ivanpovazan ivanpovazan merged commit ae904bf into dotnet:main Aug 28, 2023
111 of 114 checks passed
@ivanpovazan
Copy link
Member Author

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5998341091

@ivanpovazan ivanpovazan deleted the system-io-hashing-tests-ios branch August 29, 2023 08:35
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] Tests System.IO.Hashing.Tests.Crc32Tests crashing on tvos-arm64
2 participants