Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [mono] Enable System.IO.Hashing tests on ios and disable them on tvos #91195

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 28, 2023

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

This change contributes towards having a green runtime-extra-platforms pipeline by keeping the same test coverage on iOS-like platforms.

Testing

This can be verified by inspecting whether System.IO.Hashing.Tests have been ran and passed as part of ios-arm64 Release AllSubsets_Mono job (e.g., https://helix.dot.net/api/jobs/a48cda4a-ca96-46e6-a3c0-43c11ea1a441/workitems?api-version=2019-06-17).
Additionally, it should be verified that the tvos-arm64 Release AllSubsets_Mono is not running the System.IO.Hashing.Tests tests

Risk

This is a CI infrastructure change with low risk.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 28, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ghost
Copy link

ghost commented Aug 28, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90984 to release/8.0

/cc @ivanpovazan

Customer Impact

This change contributes towards having a green runtime-extra-platforms pipeline by keeping the same test coverage on iOS-like platforms.

Testing

This can be verified by inspecting whether System.IO.Hashing.Tests have been ran and passed as part of ios-arm64 Release AllSubsets_Mono job (e.g., https://helix.dot.net/api/jobs/a48cda4a-ca96-46e6-a3c0-43c11ea1a441/workitems?api-version=2019-06-17).
Additionally, it should be verified that the tvos-arm64 Release AllSubsets_Mono is not running the System.IO.Hashing.Tests tests

Risk

This is a CI infrastructure change with low risk.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-Infrastructure-mono

Milestone: -

@ivanpovazan ivanpovazan added this to the 8.0.0 milestone Aug 28, 2023
@ivanpovazan
Copy link
Member

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@SamMonoRT
Copy link
Member

@marek-safar @jeffschwMSFT - this one is ready as well, needs your approval. This ensures a cleaner CI on tvos, while enabling the test on iOS. No code product changes.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. this can be merged when ready

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 28, 2023
@SamMonoRT
Copy link
Member

cc @carlossanlop - this is ready to be merged

@carlossanlop carlossanlop merged commit 77f36e7 into release/8.0 Aug 28, 2023
108 of 114 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90984-to-release/8.0 branch August 28, 2023 18:06
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants