-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement standalone GC loading in NativeAOT #91038
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis is currently a prototype - the silly naming reflects that. It probably doesn't work in the integrated settings yet, creating this PR to test only. Highlights:
Lowlights:
|
4792c9d
to
f7c2083
Compare
f7c2083
to
f0ca71c
Compare
0533b9c
to
5d0031a
Compare
5d0031a
to
08ab7b4
Compare
d930166
to
a52c6a7
Compare
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
a52c6a7
to
c789a56
Compare
c7b48e7
to
fc2554d
Compare
Do we want a test so that the CI tests this? How is standalone GC tested on CoreCLR? |
StandaloneGC is supposed to be tested here as a separate pipeline that turns it on for all tests. To my surprise, the pipeline is currently disabled. I will follow up with the @dotnet/gc team on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
This is breaking the official build because of the new files https://dev.azure.com/dnceng/internal/_build/results?buildId=2285567&view=logs&j=1c10cb4a-4b1f-5dd9-3ecf-f4bf860ca96c&t=fce58ae7-1d52-5960-3c80-bf99aa5956a2&l=2360 |
I opened #93181 based on the error message |
This is currently a prototype - the silly naming reflects that. It probably doesn't work in the integrated settings yet, creating this PR to test only.
Highlights:
Lowlights:
@dotnet/gc