Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Add EmccMaximumHeapSize to define maximum memory #91256

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 29, 2023

  • Add new MSBuild property EmccMaximumHeapSize as a shorthand for emcc -s MAXIMUM_MEMORY=....

Contributes to #84638

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Aug 29, 2023
@maraf maraf added this to the 9.0.0 milestone Aug 29, 2023
@maraf maraf self-assigned this Aug 29, 2023
@maraf maraf requested a review from radical as a code owner August 29, 2023 09:24
@maraf maraf requested a review from lambdageek August 29, 2023 09:24
@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add new MSBuild property EmccMaximumHeapSize as a shorthand for emcc -s sMAXIMUM_MEMORY=....

Contributes to #84638

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono, os-browser

Milestone: 9.0.0

@maraf maraf requested a review from pavelsavara August 29, 2023 09:24
@maraf maraf merged commit 8e96ffa into dotnet:main Aug 29, 2023
31 checks passed
@maraf
Copy link
Member Author

maraf commented Aug 29, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6014718052

@maraf maraf deleted the WasmMaxMemory branch August 30, 2023 07:30
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants