Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [browser] Add EmccMaximumHeapSize to define maximum memory #91277

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2023

Backport of #91256 to release/8.0

/cc @maraf

Customer Impact

Add user an easy way to declare a maximum memory that the app has access to.

Testing

Manual

Risk

None. No change by default

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@github-actions github-actions bot requested a review from radical as a code owner August 29, 2023 16:04
@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Aug 29, 2023
@maraf maraf added this to the 8.0.0 milestone Aug 29, 2023
@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91256 to release/8.0

/cc @maraf

Customer Impact

Add user an easy way to declare a maximum memory that the app has access to.

Testing

Manual

Risk

None. No change by default

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-Build-mono, os-browser

Milestone: -

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Aug 29, 2023
@lambdageek
Copy link
Member

@maraf @lewing We should add something to https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/blazor about making Blazor apps for mobile devices. In particular it seems like apps that want to support mobile Safari will need <EmccMaximumHeapSize>268435456</EmccMaximumHeapSize> (256MiB). Not sure if we have any specific Android guidance.

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 29, 2023
@carlossanlop carlossanlop merged commit 36b3790 into release/8.0 Aug 29, 2023
33 of 38 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91256-to-release/8.0 branch August 29, 2023 23:40
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants