Fix NativeAOT unhandled exception stack trace #91415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change to add a new exception handling mechanism to coreclr has broken stack traces on unhandled exceptions in nativeaot. This change fixes it by reverting the part of the change that caused the problem and that turned out to not to be needed for the new exception handling either. Close dotnet#91298
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThe recent change to add a new exception handling mechanism to coreclr has broken stack traces on unhandled exceptions in nativeaot. This change fixes it by reverting the part of the change that caused the problem and that turned out to not to be needed for the new exception handling either. Close #91298
|
|
Should we add a smoke test for this? |
I think a regular test - that runs on all runtime flavors - would be enough. |
|
Ok, let me add a test here. |
jkotas
reviewed
Sep 3, 2023
jkotas
reviewed
Sep 3, 2023
jkotas
reviewed
Sep 3, 2023
|
The test needs fixes for Mono (Mono uses different exit code and different formatting of the output). |
janvorli
force-pushed
the
fix-nativeaot-unhandled-exception-stack-trace
branch
from
df6b500
to
d9defde
Compare
janvorli
force-pushed
the
fix-nativeaot-unhandled-exception-stack-trace
branch
from
d9defde
to
f148f79
Compare
|
Thank you! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change to add a new exception handling mechanism to coreclr has broken stack traces on unhandled exceptions in nativeaot.
This change fixes it by reverting the part of the change that caused the problem and that turned out to not to be needed for the new exception handling either.
Close #91298