Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the check for illegal type recursion to the EnsureLoadableType implementation #91707

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Port the check for illegal type recursion to the EnsureLoadableType implementation #91707

merged 1 commit into from
Sep 7, 2023

Conversation

davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Sep 7, 2023 •
edited
Loading

  • Algorithm described in ECMA 335 II.9.2 Generics and recursive inheritance graphs)
  • Reuse the Tarjan algorithm logic for this

Fixes #89545

@davidwrighton
Port the check for illegal type recursion to the EnsureLoadableType i…
1fe4890 
…mplementation

- Algorithm described in ECMA 335 II.9.2 Generics and recursive inheritance graphs)
- Reuse the Tarjan algorithm logic for this
@ghost ghost assigned davidwrighton Sep 7, 2023
@davidwrighton davidwrighton requested a review from trylek September 7, 2023 01:01
@ghost
Copy link

ghost commented Sep 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Algorithm described in ECMA 335 II.9.2 Generics and recursive inheritance graphs)
  • Reuse the Tarjan algorithm logic for this
Author: davidwrighton
Assignees: davidwrighton
Labels:

area-NativeAOT-coreclr
Milestone: -

@davidwrighton
Copy link
Member Author

I don't think this is worth porting to the release branch. If we need to fix the test there, I think we should just disable the test.

This was referenced Sep 7, 2023
Closed
Closed
trylek
trylek approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks David! I agree we shouldn't need to backport this change to .NET 8, after all the release branch has at least my original hotfix limiting the recursion depth.

@davidwrighton davidwrighton merged commit 0310abf into dotnet:main Sep 7, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@davidwrighton davidwrighton

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure Loader/classloader/generics/regressions/DD117522/Test/Test.sh
2 participants
@davidwrighton @trylek