Remove uses of IlcTrimMetadata from the test tree #91774
Conversation
We want to be testing the shipping configuration. I left it in two test projects because the uses there were too annoying to fix up. For System.Security, the problem is in non-trimmability of the APIs and would need RD.XML/whatever. For Vectors, the problem is in the use of `dynamic` in the tests due to laziness and I'm equally lazy to rewrite all of it. Fixes dotnet#71506.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis is basically just making tests trimmable. We want to be testing the shipping configuration without weird switches. I left IlcTrimMetadata in two test projects because the uses there were too annoying to fix up. For System.Security, the problem is in non-trimmability of the APIs and would need RD.XML/whatever. For Vectors, the problem is in the use of Fixes #71506. Cc @dotnet/ilc-contrib
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Numerics.Vectors/tests/System.Numerics.Vectors.Tests.csproj
Outdated
Show resolved
Hide resolved
| Type t = typeof(XmlConvert).Assembly.GetType("System.Xml.LocalAppContextSwitches"); | ||
| Type t = Type.GetType("System.Xml.LocalAppContextSwitches, System.Private.Xml"); |
There was a problem hiding this comment.
I've been seeing so much of this lately that I'm wondering if we should just implement the necessary data flow for this.
There was a problem hiding this comment.
👍 this is my favorite go to way of doing things
There was a problem hiding this comment.
The sad part is that even if we implement it (which I think we should) it will only work when the app targets net9+. It's not much use for almost every library out there right now. It will take something like 4 years to really be usable by libraries.
And backporting it to .NET 6 is... difficult to say the least.
…ctors.Tests.csproj Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
This is basically just making tests trimmable. We want to be testing the shipping configuration without weird switches.
I left IlcTrimMetadata in two test projects because the uses there were too annoying to fix up. For System.Security, the problem is in non-trimmability of the APIs and would need RD.XML/whatever. For Vectors, the problem is in the use of
dynamicin the tests due to laziness and I'm equally lazy to rewrite all of it.Fixes #71506.
Cc @dotnet/ilc-contrib