#ifdef out code that requires FEATURE_EVENT_TRACE

[yowl]

This PR follows #90847 and removes some more code when FEATURE_EVENT_TRACE is not defined. Surfaced as part of dotnet/runtimelab#2396

Not sure about the gcrhenv.cpp change. Maybe I should be removing all the DiagGC* methods and #ifdefing their usages ?

cc @EgorBo

Thanks

[ghost]

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This PR follows #90847 and removes some more code when FEATURE_EVENT_TRACE is not defined. Surfaced as part of dotnet/runtimelab#2396

Not sure about the gcrhenv.cpp change. Maybe I should be removing all the DiagGC* methods and #ifdefing their usages ?

cc @EgorBo

Thanks

Author:	yowl
Assignees:	-
Labels:	area-GC-coreclr
Milestone:	-

[EgorBo]

LGTM, but leaving for @dotnet/gc to approve/merge

[Maoni0]

Maybe I should be removing all the DiagGC* methods

you should not remove the methods as GC is still expecting to call them.

for the changed related to the FEATURE_EVENT_TRACE ifdef checks in gc.cpp, why are only some removed but not all?

[EgorBo]

The one in gc_heap::update_ro_segment is just my fault - I used use_frozen_segments_p in an assert and that variable is only available when FEATURE_EVENT_TRACE is defined.

We can also just remove the assert - it doesn't add a lot of value

[yowl]

We can also just remove the assert - it doesn't add a lot of value

I have no preference here.

[yowl]

Sorry I closed this by mistake.

for the changed related to the FEATURE_EVENT_TRACE ifdef checks in gc.cpp, why are only some removed but not all?

I've gone ahead and just removed the assert so gc.cpp only has that as a change. @Maoni0 is there anything else I can answer or change here? Thanks.

[EgorBo]

LGTM, but leaving for @dotnet/gc to review/merge

[mangod9]

@cshung, can you please review and merge?

[TheSpydog]

Is this fix going to be merged into a .NET 8.x release? For our game console ports of NativeAOT, we do not enable FEATURE_EVENT_TRACE, so we’re running into compile errors when upgrading our runtime support to .NET 8.

[jkotas]

/backport to release/8.0-staging

[github-actions]

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6867071751

[jkotas]

We will take it for consideration. We do not typically backport fixes for custom configuration like this one, but I think we can make an exception for this one given that it is a regression from .NET 7, it is shortly after release and the fix is very low risk.