Change GetParametersNoCopy to GetParametersAsSpan and use it in a few more places #92310
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsThe internal GetParametersNoCopy avoids a defensive ParameterInfo[] copy, but it requires the callers to promise not to mutate the array. I'm changing the method to return a
|
|
Nit: Existing art |
stephentoub
requested review from
marek-safar and
MichalStrehovsky
as code owners
src/libraries/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs
Show resolved
Hide resolved
… more places The internal GetParametersNoCopy avoids a defensive ParameterInfo[] copy, but it requires the callers to promise not to mutate the array. I'm changing the method to return a `ReadOnlySpan<ParameterInfo>`, which means a caller can't mutate it without using unsafe code, and enabling the compiler to flag any misuse. I've then used it in a few more places. We might subsequently want to consider exposing it publicly.
stephentoub
force-pushed
the
getparametersnocopy
branch
from
4513e90
to
8f6db68
Compare
stephentoub
changed the title
src/libraries/Common/src/System/Runtime/InteropServices/ComEventsMethod.cs
Outdated
Show resolved
Hide resolved
|
/azp list |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Both failures are known and tracked. I ran extra platforms as well, and all of those also appear to be known, with the exception of some recently added LINQ tests failing on nativeaot for which I opened an issue. |
The internal GetParametersNoCopy avoids a defensive ParameterInfo[] copy, but it requires the callers to promise not to mutate the array. I'm changing the method to return a
ReadOnlySpan<ParameterInfo>, which means a caller can't mutate it without using unsafe code, and enabling the compiler to flag any misuse. I've then used it in a few more places. We might subsequently want to consider exposing it publicly.