Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Support indexing of valuetype scheme #92637
[wasm][debugger] Support indexing of valuetype scheme #92637
Changes from 13 commits
6d988af
8c99fd3
116200b
ec15434
c5e8792
4b3e6c1
21841f7
a8a2ee4
52dd1f8
6781416
c4595c4
39ace3a
98c6db3
5d41e6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is needed, or missing to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your idea here is the better approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason why it might be not possible:
CMD_VM_INVOKE_METHOD
and it will throw / return a result.It would be good to try if something changed but please, not in this PR. I will see if I can make it in a separate one.
Edit:
Trying to create the new PR I found a good example for situation 1).
When we ask for
GetMethodIdsByName
for "foo" we will get both methods' IDs. We can check both method parameter types by refection but the information we will get isElementType.Class
which does not tell us enough.