Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] logging and exit improvements #93472

Merged
merged 8 commits into from
Nov 1, 2023
Merged

[browser] logging and exit improvements #93472

merged 8 commits into from
Nov 1, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 13, 2023 •
edited
Loading

This whole PR is motivated by making mono_wasm_exit to be used.

  • until now, it never run because the condition guarding it was always false
  • we need it to run, so that MT build would stop all workers
  • use emscripten_force_exit

Other fixes

  • remember reason message of the abort
  • refactor logging.ts, WS event handlers
  • add native stdout and stdin flush
  • test SecondRuntimeTest.js silently
  • added one timer loop pass to mono_run_main so that queued tasks could finish running
  • make all engines "NO_EXIT_RUNTIME=0" and balance it with runtimeKeepalivePush, runtimeKeepalivePop
  • skip dryRun in test-main when we are not in secure context
  • reorder virtualWorkingDirectory after memory snapshot
  • refactor Module exit hooks into register_exit_handlers and unregister_exit_handlers

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Oct 13, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 13, 2023
@pavelsavara pavelsavara self-assigned this Oct 13, 2023
@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • remember reason message of the abort
  • refactor logging.ts, WS event handlers
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara mentioned this pull request Oct 13, 2023
Merged
This was referenced Oct 13, 2023
Open
Open
Closed
@pavelsavara pavelsavara mentioned this pull request Oct 17, 2023
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara mentioned this pull request Oct 17, 2023
Merged
@pavelsavara pavelsavara marked this pull request as ready for review October 17, 2023 09:43
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 17, 2023
Closed
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@build-analysis build-analysis bot mentioned this pull request Oct 30, 2023
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

CI failures are #94221

@radical
Copy link
Member

radical commented Oct 31, 2023

CI failures are #94221

Please merge that before this PR, so we can merge this one on green for WBT.

@radical
Copy link
Member

radical commented Oct 31, 2023

CI failures are #94221

Please merge that before this PR, so we can merge this one on green for WBT.

Ignore that, since this is breaking on main.

This was referenced Oct 31, 2023
Closed
Closed
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Merge branch 'main' into browser_logging_improvements
3bb35fb 
# Conflicts:
#	src/mono/wasm/test-main.js
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

All CI failures are known

@pavelsavara pavelsavara merged commit eb11cc3 into dotnet:main Nov 1, 2023
124 of 131 checks passed
@pavelsavara pavelsavara deleted the browser_logging_improvements branch November 1, 2023 15:55
@pavelsavara pavelsavara mentioned this pull request Nov 30, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg left review comments

@maraf maraf maraf approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@radical radical Awaiting requested review from radical

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelsavara @radical @kg @ViktorHofer @maraf