Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Disable AOT Hybrid Globalization wbt #94221

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 31, 2023

The wbt with HG and AOT is failing with error The type initializer for 'System.Globalization.CultureInfo' threw an exception. after exposing Lock type (= after merging in #87672). I do not see direct reason for the failure yet, disabling for the time of investigation.

Active issue: #94212

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue labels Oct 31, 2023
@ilonatommy ilonatommy self-assigned this Oct 31, 2023
@ghost
Copy link

ghost commented Oct 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The wbt with HG and AOT is failing after exposing Lock wit error The type initializer for 'System.Globalization.CultureInfo' threw an exception. I do not see direct reason for the failure yet, disabling for the time of investigation.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization, disabled-test

Milestone: -

@radical
Copy link
Member

radical commented Oct 31, 2023

after exposing Lock type

Could you please elaborate?

@ilonatommy
Copy link
Member Author

ilonatommy commented Oct 31, 2023

after exposing Lock type

Could you please elaborate?

Description edited, I meant merging the PR with that title

@ilonatommy ilonatommy changed the title [browser] Disable AOT Hybrid Globalization wbt [browser] Disable AOT Hybrid Globalization wbt on V8 Oct 31, 2023
@ilonatommy ilonatommy changed the title [browser] Disable AOT Hybrid Globalization wbt on V8 [browser] Disable AOT Hybrid Globalization wbt Oct 31, 2023
@pavelsavara pavelsavara merged commit ac95ec9 into dotnet:main Oct 31, 2023
22 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Globalization disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants