Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for determinism #93600

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add a test for determinism #93600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54ef3eb
Add a test for determinism
MichalStrehovsky Oct 17, 2023
561baef
Call into the other test
MichalStrehovsky Oct 19, 2023
e62fce7
Merge branch 'main' into dettest
MichalStrehovsky Oct 30, 2023
9a34862
Merge branch 'main' into dettest
MichalStrehovsky Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions src/tests/nativeaot/SmokeTests/Determinism/Determinism.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.IO;

using var baseline = File.OpenRead("baseline.object");
using var compare = File.OpenRead("compare.object");
Comment on lines +7 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoke these via reflection? Downstream, I have seen determinism issues (RyuJit-induced, since then fixed) pop up in reflection internals.


Console.WriteLine($"Baseline size: {baseline.Length}");
Console.WriteLine($"Compare size: {compare.Length}");

if (baseline.Length != compare.Length)
throw new Exception("Different sizes");

long length = baseline.Length;
for (int i = 0; i < length; i++)
{
if (baseline.ReadByte() != compare.ReadByte())
throw new Exception($"Different at byte {i}");
}

// We're not interested in running this, we just want some junk to compile
if (Environment.GetEnvironmentVariable("Never") == "Ever")
{
Delegates.Run();
Devirtualization.Run();
Generics.Run();
Interfaces.Run();
}

return 100;
42 changes: 42 additions & 0 deletions src/tests/nativeaot/SmokeTests/Determinism/Determinism.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<CLRTestPriority>0</CLRTestPriority>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
<Compile Include="Determinism.cs" />
<Compile Include="../UnitTests/Delegates.cs" />
<Compile Include="../UnitTests/Devirtualization.cs" />
<Compile Include="../UnitTests/Generics.cs" />
<Compile Include="../UnitTests/Interfaces.cs" />

</ItemGroup>

<Target Name="IlcCompileSingleThreaded"
Inputs="$(NativeIntermediateOutputPath)%(ManagedBinary.Filename)$(IlcOutputFileExt)"
Outputs="$(NativeIntermediateOutputPath)%(ManagedBinary.Filename)$(IlcOutputFileExt)-singlethreaded"
AfterTargets="IlcCompile">

<PropertyGroup>
<OldObjectFileName>$(NativeIntermediateOutputPath)%(ManagedBinary.Filename)$(IlcOutputFileExt)</OldObjectFileName>
<NewObjectFileName>$(NativeIntermediateOutputPath)%(ManagedBinary.Filename)$(IlcOutputFileExt)-singlethreaded</NewObjectFileName>
</PropertyGroup>

<ItemGroup>
<IlcArg Remove="-o:$(OldObjectFileName)" />
<IlcArg Include="-o:$(NewObjectFileName)" />
<IlcArg Include="--parallelism:1" />
</ItemGroup>

<WriteLinesToFile File="%(ManagedBinary.IlcRspFile)-singlethreaded" Lines="@(IlcArg)" Overwrite="true" WriteOnlyWhenDifferent="true" />

<Message Text="Compiling single-threaded baseline" Importance="High" />

<Exec Command="&quot;$(IlcToolsPath)\ilc&quot; @&quot;%(ManagedBinary.IlcRspFile)-singlethreaded&quot;"
EnvironmentVariables="$(_IlcEnvironmentVariables)" />

<Copy SourceFiles="$(OldObjectFileName)" DestinationFiles="$(OutDir)\baseline.object" />
<Copy SourceFiles="$(NewObjectFileName)" DestinationFiles="$(OutDir)\compare.object" />
</Target>
</Project>
Loading