[release/8.0] [mono] Disallow casts of bounded arrays to array special interfaces

[github-actions]

Backport of #93616 to release/8.0

/cc @lambdageek

Customer Impact

Customers on mobile and WebAssembly platforms using bounded array types may experience crashes if the arrays are incorrectly cast to certain generic interface types. The correct behavior is to throw an InvalidCastException. This may impact customers using certain versions of xUnit for testing their mobile or WASM applications.

Testing

New CI test

Risk

Low

[MichalStrehovsky]

The test needs to be disabled on Native AOT. We don't support arrays with non-zero lower bounds.

[MichalStrehovsky]

The test needs to be disabled on Native AOT. We don't support arrays with non-zero lower bounds.

Should be added to the collection here:

runtime/src/tests/issues.targets

Lines 1119 to 1155 in 0a188dd

	<!-- Arrays with non-zero lower bounds -->
	<!-- https://github.com/dotnet/runtimelab/issues/155 -->
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_b_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_i4_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_objref_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_r4_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_r8_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_struct_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\huge\huge_u8_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\address_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\ldelem_get_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\address_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\gcarr_il_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\misc\ldelem_get_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range1_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range2_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_1_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_m1_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_neg_range_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range1_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range2_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range1_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\float64_range2_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_1_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_m1_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_neg_range_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range1_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\Arrays\range\int32_range2_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\int64\arrays\hugedim_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array2_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array3_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\refany\array3_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\tailcall\deep_array_nz_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\tailcall\deep_array_nz_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\VT\port\huge_gcref_d\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical\VT\port\huge_gcref_r\*" />
	<ExcludeList Include="$(XunitTestBinBase)/JIT/Performance/CodeQuality/Benchstones/MDBenchI/MDGeneralArray/MDGeneralArray/*" />

[carlossanlop]

@MichalStrehovsky @lambdageek is there an additional test that needs to be disabled? There's a failure:

• Queue: Build windows-x64 Checked NativeAOT
• Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=442686&view=logs&j=ea7d6d51-d18d-5306-47bd-e3b7db04467e&t=64748b58-8f78-5277-67c1-1790606dd9c0&l=29
• Log file: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-93617-merge-8d43e23f3b464b91bf/Loader.classloader/1/console.03fe9c6e.log?helixlogtype=result

Unhandled Exception: System.PlatformNotSupportedException: Arrays with non-zero lower bounds are not supported.

[lambdageek]

@MichalStrehovsky @lambdageek is there an additional test that needs to be disabled? There's a failure:

• Queue: Build windows-x64 Checked NativeAOT
• Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=442686&view=logs&j=ea7d6d51-d18d-5306-47bd-e3b7db04467e&t=64748b58-8f78-5277-67c1-1790606dd9c0&l=29
• Log file: https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-93617-merge-8d43e23f3b464b91bf/Loader.classloader/1/console.03fe9c6e.log?helixlogtype=result

Unhandled Exception: System.PlatformNotSupportedException: Arrays with non-zero lower bounds are not supported.

That's the test I tried to exclude. But I think I messed up the exclude target

[lambdageek]

Approved by tactics in email

[carlossanlop]

CI failure unrelated (KnownBuildError didn't tag it automatically): #90639