[release/8.0] Fix analysis of interface methods on generic types #93748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93540 to release/8.0
/cc @agocke @MichalStrehovsky
Customer Impact
This is not a regression.
This is an internal error in the AOT compiler when hitting a particular combination of interfaces on generic types. It was originally found in the
main
branch ofdotnet/runtime
when trying to upgrade various versions, but it has subsequently been revealed as being easy to hit in customer workloads as well. It's possible, but very complicated, to workaround this issue. It's also a complex internal error so it's difficult to determine that this bug is the source of the problem.Testing
Unit tests, fixing the
dotnet/runtime
integration tests inmain
.Risk
Low. Only affects Native AOT. We're reusing the same algorithm for interface analysis that we're using in another part of the compiler.