-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Stable branding for .NET 8 GA #93807
[release/8.0] Stable branding for .NET 8 GA #93807
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis is it folks.
|
This needs #93801 to land first as things are. I can work around that but not tonight |
Failure now in runtime (Build windows-x64 Checked NativeAOT) is
|
Why didn't this show up in servicing readiness? cc @dkurepa |
Not sure why it didn't show up in servicing readiness but we probably need to add this override to NativeAOT corelib, it is there both in CoreCLR and Mono corelib:
Some more discussion in this issue: #60532 |
Here's the test:
Its checking the runtime/eng/versioning.targets Line 167 in 0f2cf16
|
I'm not sure. I just checked and it definitely didn't show up |
This is actually not a regression, I checked the 7.0.12 version of the NativeAOT
... while a normal Microsoft.NETCore.App.Runtime.linux-x64 CoreCLR runtime pack does not:
I assume this test didn't run on NativeAOT in 7.0. |
@akoeplinger are you the right person to look into this remaining failure? |
@carlossanlop yes I'm 99% sure I know the fix, if it works should I push to this PR or should we go to main first and then backport? |
|
Actually, since we're late, i think it will be better to do main + submit the fix to this PR directly, not backport. @akoeplinger |
Pushed, main PR is in #93889 |
Changes look OK to me, but FWIW Roslyn always ships with a suffix in the version. It doesn't seem like we care much either way. This test seems overly aggressive to me. |
Thanks, please merge ASAP. |
@agocke this is actually exposed through Lines 14 to 34 in 64b93dd
|
We need to make sure the string contains only the stabilized version in servicing, or a non-stabilized one otherwise. This prevents issues like dotnet#45812 and what we hit in dotnet#93807. Closes dotnet#45812
…otnet#93913) We need to make sure the string contains only the stabilized version in servicing, or a non-stabilized one otherwise. This prevents issues like dotnet#45812 and what we hit in dotnet#93807. Closes dotnet#45812
This is it folks.