-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging][wasm] WBT Stop taking latest sdk in release/8.0 #94097
[release/8.0-staging][wasm] WBT Stop taking latest sdk in release/8.0 #94097
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue Detailsnull
|
@carlossanlop infra only, fixes the wasm failures in release/8.0* |
Is this blocking release/8.0? If yes, then we should merge, but @mmitche needs to confirm. Otherwise, can you please target 8.0-staging? Because as of right now, the branch is closed. |
It is just fixing tests, we can just target staging and ignore the failures if we need to take anything more into release/8.0 |
Okay thanks, please retarget: edit the PR title, switch the branch in the dropdown. Note that sometimes git changes the branch in a bad way and ends up bringing in thinks we don't want, so please double check. |
I'll retarget once CI finishes then I'd suggest fast merging there |
This is now all the |
13e0d54
to
d92f5a9
Compare
removed the other commits |
fast merging to unblock staging |
b261d02
into
dotnet:release/8.0-staging
It looks like wasm build tests have started picking up 8.0.2xx sdks after being unpinned. This pins the WBT sdk to a recent 8.0.1xx sdk which should be new enough for testing and not contain the workload set changes. We could probably set the channel correctly for 1xx and unpin but that can happen later.
We will need to fix wbt for the workload set changes but that definitely doesn't need to happen before 8.0.0.
Fixes #93900