Rename IsMacOS to IsApplePlatform in the JIT #96090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we use it on iOS/tvOS as well, rename the variables to match. Fixes dotnet#87610
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNow that we use it on iOS/tvOS as well, rename the variables to match. Fixes #87610
|
Why not IsApplePlatform which we have used elsewhere? Or should we rename those to IsAppleOS (to rhyme with Target"OS")? |
|
I don't particularly care, another option would be using IsOSXLike which we've used in ILC. |
Well, introducing new name is not being consistent, which is the whole premise of this change. ;) % git grep -i isappleplatform | wc -l
70
% git grep -i isappleos | wc -l
0 |
|
Ok, renamed to IsApplePlatform and fixed a few other instances where we referred to osx/macos |
akoeplinger
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use it on iOS/tvOS as well, rename the variables to match.
Fixes #87610