Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Do not throw in AssemblyExtensions.TryGetRawMetadata. #96370

Merged
merged 3 commits into from
Feb 17, 2024
Merged

[mono] Do not throw in AssemblyExtensions.TryGetRawMetadata. #96370

merged 3 commits into from
Feb 17, 2024

Conversation

teo-tsirpanis
Copy link
Contributor

A Try*** method should not throw. This PR changes the method to return false, just like Native AOT.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 30, 2023
@ghost
Copy link

ghost commented Jan 19, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

A Try*** method should not throw. This PR changes the method to return false, just like Native AOT.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Reflection, runtime-mono, community-contribution, area-System.Reflection-mono
Milestone: -

@buyaa-n buyaa-n added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 25, 2024
@ghost ghost added the no-recent-activity label Feb 9, 2024
@ghost
Copy link

ghost commented Feb 9, 2024

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost ghost removed needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity labels Feb 11, 2024
@build-analysis build-analysis bot mentioned this pull request Feb 11, 2024
Closed
@buyaa-n buyaa-n added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 14, 2024
@teo-tsirpanis teo-tsirpanis removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 17, 2024
stephentoub
stephentoub approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jkotas jkotas mentioned this pull request Feb 17, 2024
Closed
jkotas
jkotas approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 9a391bc into dotnet:main Feb 17, 2024
134 of 138 checks passed
@teo-tsirpanis teo-tsirpanis deleted the mono-asm-raw-md branch February 17, 2024 15:31
This was referenced Feb 17, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@stephentoub stephentoub stephentoub approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@lambdageek lambdageek Awaiting requested review from lambdageek

Assignees
No one assigned
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member runtime-mono specific to the Mono runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@teo-tsirpanis @stephentoub @jkotas @jeffschwMSFT @buyaa-n