Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT/ARM] Fix unwinding over floating point registers #97863

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[NativeAOT/ARM] Fix unwinding over floating point registers #97863

merged 1 commit into from
Feb 2, 2024

Conversation

filipnavara
Copy link
Member

The EHABI unwinder needs the Registers class to implement FP registers properly or it ends up not adjusting the stack pointer and returns garbage. The ABI also specifies to preserve the D8-D15 registers so add that.

Contributes to #97729

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The EHABI unwinder needs the Registers class to implement FP registers properly or it ends up not adjusting the stack pointer and returns garbage. The ABI also specifies to preserve the D8-D15 registers so add that.

Contributes to #97729

Author: filipnavara
Assignees: -
Labels:

community-contribution, area-NativeAOT-coreclr
Milestone: -

@filipnavara filipnavara mentioned this pull request Feb 2, 2024
Open
16 tasks
This was referenced Feb 2, 2024
Closed
Closed
Closed
jkotas
jkotas approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 7f02aef into dotnet:main Feb 2, 2024
107 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-arm32 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @jkotas