Preserve all InternalsVisibleTo attributes in ILLink Trimmer #98910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsRemoves previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes #92582
|
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
fa9da15 to
dbd86c0
Compare
|
@dotnet-policy-service agree |
This was referenced Feb 26, 2024
teo-tsirpanis
added
the
community-contribution
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
2 times, most recently
from
4d7d955 to
2edac38
Compare
This was referenced Mar 4, 2024
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
2edac38 to
048a932
Compare
dotnet-policy-service
bot
added
the
linkable-framework
sbomer
reviewed
Apr 9, 2024
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/IVTUnused.cs
Outdated
Show resolved
Hide resolved
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
048a932 to
25906e9
Compare
Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes dotnet#92582
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
25906e9 to
9144ba6
Compare
sbomer
approved these changes
Apr 10, 2024
|
@sbomer is this waiting for someone else's review? |
|
Nope, merged. |
|
Thanks @sbomer. Is there any follow up actions required from my end? What sort of timeline could I expect to see this included in a release? |
|
No action required. You should see it included in the next .NET 9 preview release (preview 4). |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…98910) Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes dotnet#92582
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction.
Fixes #92582